Skip to content

Commit 3b07bb9

Browse files
t-8chfbq
authored andcommitted
leds: lp8860: Check return value of devm_mutex_init()
devm_mutex_init() can fail. With CONFIG_DEBUG_MUTEXES=y the mutex will be marked as unusable and trigger errors on usage. Add the missed check. Fixes: 87a5954 ("leds: lp8860: Use new mutex guards to cleanup function exits") Signed-off-by: Thomas Weißschuh <[email protected]> Acked-by: Andrew Davis <[email protected]> Acked-by: Lee Jones <[email protected]> Signed-off-by: Boqun Feng <[email protected]> Link: https://lore.kernel.org/r/20250617-must_check-devm_mutex_init-v7-2-d9e449f4d224@weissschuh.net
1 parent d24a54e commit 3b07bb9

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/leds/leds-lp8860.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,9 @@ static int lp8860_probe(struct i2c_client *client)
307307
led->client = client;
308308
led->led_dev.brightness_set_blocking = lp8860_brightness_set;
309309

310-
devm_mutex_init(&client->dev, &led->lock);
310+
ret = devm_mutex_init(&client->dev, &led->lock);
311+
if (ret)
312+
return dev_err_probe(&client->dev, ret, "Failed to initialize lock\n");
311313

312314
led->regmap = devm_regmap_init_i2c(client, &lp8860_regmap_config);
313315
if (IS_ERR(led->regmap)) {

0 commit comments

Comments
 (0)