Skip to content

Commit 3d88ba8

Browse files
author
Jiri Kosina
committed
Revert "HID: multitouch: Add support for lenovo Y9000P Touchpad"
This reverts commit 251efae. Quoting Wang Yuli: "The 27C6:01E0 touchpad doesn't require the workaround and applying it would actually break functionality. The initial report came from a BBS forum, but we suspect the information provided by the forum user may be incorrect which could happen sometimes. [1] Further investigation showed that the Lenovo Y9000P 2024 doesn't even use a Goodix touchpad. [2] For the broader issue of 27c6:01e0 being unusable on some devices, it just need to address it with a libinput quirk. In conclusion, we should revert this commit, which is the best solution." Reported-by: Ulrich Müller <[email protected]> Reported-by: WangYuli <[email protected]> Link: https://lore.kernel.org/all/[email protected]/ Signed-off-by: Jiri Kosina <[email protected]>
1 parent e02b876 commit 3d88ba8

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

drivers/hid/hid-ids.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,6 @@
506506
#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100 0xe100
507507

508508
#define I2C_VENDOR_ID_GOODIX 0x27c6
509-
#define I2C_DEVICE_ID_GOODIX_01E0 0x01e0
510509
#define I2C_DEVICE_ID_GOODIX_01E8 0x01e8
511510
#define I2C_DEVICE_ID_GOODIX_01E9 0x01e9
512511
#define I2C_DEVICE_ID_GOODIX_01F0 0x01f0

drivers/hid/hid-multitouch.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1460,8 +1460,7 @@ static const __u8 *mt_report_fixup(struct hid_device *hdev, __u8 *rdesc,
14601460
{
14611461
if (hdev->vendor == I2C_VENDOR_ID_GOODIX &&
14621462
(hdev->product == I2C_DEVICE_ID_GOODIX_01E8 ||
1463-
hdev->product == I2C_DEVICE_ID_GOODIX_01E9 ||
1464-
hdev->product == I2C_DEVICE_ID_GOODIX_01E0)) {
1463+
hdev->product == I2C_DEVICE_ID_GOODIX_01E9)) {
14651464
if (rdesc[607] == 0x15) {
14661465
rdesc[607] = 0x25;
14671466
dev_info(
@@ -2085,10 +2084,7 @@ static const struct hid_device_id mt_devices[] = {
20852084
I2C_DEVICE_ID_GOODIX_01E8) },
20862085
{ .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU,
20872086
HID_DEVICE(BUS_I2C, HID_GROUP_ANY, I2C_VENDOR_ID_GOODIX,
2088-
I2C_DEVICE_ID_GOODIX_01E9) },
2089-
{ .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU,
2090-
HID_DEVICE(BUS_I2C, HID_GROUP_ANY, I2C_VENDOR_ID_GOODIX,
2091-
I2C_DEVICE_ID_GOODIX_01E0) },
2087+
I2C_DEVICE_ID_GOODIX_01E8) },
20922088

20932089
/* GoodTouch panels */
20942090
{ .driver_data = MT_CLS_NSMU,

0 commit comments

Comments
 (0)