Skip to content

Commit 4229c28

Browse files
juhosglinusw
authored andcommitted
pinctrl: armada-37xx: propagate error from armada_37xx_pmx_set_by_name()
The regmap_update_bits() function can fail, so propagate its error up to the stack instead of silently ignoring that. Signed-off-by: Imre Kaloz <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Signed-off-by: Gabor Juhos <[email protected]> Link: https://lore.kernel.org/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent 6481c0a commit 4229c28

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/pinctrl/mvebu/pinctrl-armada-37xx.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -358,9 +358,7 @@ static int armada_37xx_pmx_set_by_name(struct pinctrl_dev *pctldev,
358358

359359
val = grp->val[func];
360360

361-
regmap_update_bits(info->regmap, reg, mask, val);
362-
363-
return 0;
361+
return regmap_update_bits(info->regmap, reg, mask, val);
364362
}
365363

366364
static int armada_37xx_pmx_set(struct pinctrl_dev *pctldev,

0 commit comments

Comments
 (0)