Skip to content

Commit 43ea403

Browse files
Miriam-Racheljmberg-intel
authored andcommitted
wifi: iwlwifi: cleanup BT Shared Single Antenna code
We don't support such device. Reviewed-by: Gregory Greenman <[email protected]> Signed-off-by: Miri Korenblit <[email protected]> Link: https://msgid.link/20231219215605.6e6961ac0ac5.I923024eac20efd24a5b42332d8e73ae756e0469a@changeid Signed-off-by: Johannes Berg <[email protected]>
1 parent 9b6614e commit 43ea403

File tree

2 files changed

+4
-19
lines changed

2 files changed

+4
-19
lines changed

drivers/net/wireless/intel/iwlwifi/iwl-config.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,6 @@ struct iwl_cfg {
377377
u16 nvm_calib_ver;
378378
u32 rx_with_siso_diversity:1,
379379
tx_with_siso_diversity:1,
380-
bt_shared_single_ant:1,
381380
internal_wimax_coex:1,
382381
host_interrupt_operation_mode:1,
383382
high_temp:1,

drivers/net/wireless/intel/iwlwifi/mvm/coex.c

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
22
/*
3-
* Copyright (C) 2013-2014, 2018-2020, 2022 Intel Corporation
3+
* Copyright (C) 2013-2014, 2018-2020, 2022-2023 Intel Corporation
44
* Copyright (C) 2013-2015 Intel Mobile Communications GmbH
55
*/
66
#include <linux/ieee80211.h>
@@ -116,11 +116,6 @@ iwl_get_coex_type(struct iwl_mvm *mvm, const struct ieee80211_vif *vif)
116116

117117
ret = BT_COEX_TX_DIS_LUT;
118118

119-
if (mvm->cfg->bt_shared_single_ant) {
120-
rcu_read_unlock();
121-
return ret;
122-
}
123-
124119
phy_ctx_id = *((u16 *)chanctx_conf->drv_priv);
125120
primary_ch_phy_id = le32_to_cpu(mvm->last_bt_ci_cmd.primary_ch_phy_id);
126121
secondary_ch_phy_id =
@@ -383,13 +378,12 @@ static void iwl_mvm_bt_notif_per_link(struct iwl_mvm *mvm,
383378
/*
384379
* don't reduce the Tx power if one of these is true:
385380
* we are in LOOSE
386-
* single share antenna product
387381
* BT is inactive
388382
* we are not associated
389383
*/
390384
if (iwl_get_coex_type(mvm, vif) == BT_COEX_LOOSE_LUT ||
391-
mvm->cfg->bt_shared_single_ant || !vif->cfg.assoc ||
392-
le32_to_cpu(mvm->last_bt_notif.bt_activity_grading) == BT_OFF) {
385+
le32_to_cpu(mvm->last_bt_notif.bt_activity_grading) == BT_OFF ||
386+
!vif->cfg.assoc) {
393387
iwl_mvm_bt_coex_reduced_txp(mvm, link_info->ap_sta_id, false);
394388
/* FIXME: should this be per link? */
395389
iwl_mvm_bt_coex_enable_rssi_event(mvm, vif, false, 0);
@@ -570,7 +564,7 @@ void iwl_mvm_bt_rssi_event(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
570564
* Check if rssi is good enough for reduced Tx power, but not in loose
571565
* scheme.
572566
*/
573-
if (rssi_event == RSSI_EVENT_LOW || mvm->cfg->bt_shared_single_ant ||
567+
if (rssi_event == RSSI_EVENT_LOW ||
574568
iwl_get_coex_type(mvm, vif) == BT_COEX_LOOSE_LUT)
575569
ret = iwl_mvm_bt_coex_reduced_txp(mvm,
576570
mvmvif->deflink.ap_sta_id,
@@ -639,10 +633,6 @@ bool iwl_mvm_bt_coex_is_mimo_allowed(struct iwl_mvm *mvm,
639633

640634
bool iwl_mvm_bt_coex_is_ant_avail(struct iwl_mvm *mvm, u8 ant)
641635
{
642-
/* there is no other antenna, shared antenna is always available */
643-
if (mvm->cfg->bt_shared_single_ant)
644-
return true;
645-
646636
if (ant & mvm->cfg->non_shared_ant)
647637
return true;
648638

@@ -652,10 +642,6 @@ bool iwl_mvm_bt_coex_is_ant_avail(struct iwl_mvm *mvm, u8 ant)
652642

653643
bool iwl_mvm_bt_coex_is_shared_ant_avail(struct iwl_mvm *mvm)
654644
{
655-
/* there is no other antenna, shared antenna is always available */
656-
if (mvm->cfg->bt_shared_single_ant)
657-
return true;
658-
659645
return le32_to_cpu(mvm->last_bt_notif.bt_activity_grading) < BT_HIGH_TRAFFIC;
660646
}
661647

0 commit comments

Comments
 (0)