Skip to content

Commit 46e6acf

Browse files
robherringkuba-moo
authored andcommitted
net: phy: qca807x: Drop unnecessary and broken DT validation
The check for "leds" and "gpio-controller" both being present is never true because "leds" is a node, not a property. This could be fixed with a check for child node, but there's really no need for the kernel to validate a DT. Just continue ignoring the LEDs if GPIOs are present. Signed-off-by: Rob Herring (Arm) <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 5fcf080 commit 46e6acf

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

drivers/net/phy/qcom/qca807x.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -733,16 +733,6 @@ static int qca807x_probe(struct phy_device *phydev)
733733
"qcom,dac-disable-bias-current-tweak");
734734

735735
#if IS_ENABLED(CONFIG_GPIOLIB)
736-
/* Make sure we don't have mixed leds node and gpio-controller
737-
* to prevent registering leds and having gpio-controller usage
738-
* conflicting with them.
739-
*/
740-
if (of_find_property(node, "leds", NULL) &&
741-
of_find_property(node, "gpio-controller", NULL)) {
742-
phydev_err(phydev, "Invalid property detected. LEDs and gpio-controller are mutually exclusive.");
743-
return -EINVAL;
744-
}
745-
746736
/* Do not register a GPIO controller unless flagged for it */
747737
if (of_property_read_bool(node, "gpio-controller")) {
748738
ret = qca807x_gpio(phydev);

0 commit comments

Comments
 (0)