Skip to content

Commit 4f86eb0

Browse files
Wang LiangPaolo Abeni
authored andcommitted
selftests: net: check jq command is supported
The jq command is used in vlan_bridge_binding.sh, if it is not supported, the test will spam the following log. # ./vlan_bridge_binding.sh: line 51: jq: command not found # ./vlan_bridge_binding.sh: line 51: jq: command not found # ./vlan_bridge_binding.sh: line 51: jq: command not found # ./vlan_bridge_binding.sh: line 51: jq: command not found # ./vlan_bridge_binding.sh: line 51: jq: command not found # TEST: Test bridge_binding on->off when lower down [FAIL] # Got operstate of , expected 0 The rtnetlink.sh has the same problem. It makes sense to check if jq is installed before running these tests. After this patch, the vlan_bridge_binding.sh skipped if jq is not supported: # timeout set to 3600 # selftests: net: vlan_bridge_binding.sh # TEST: jq not installed [SKIP] Fixes: dca12e9 ("selftests: net: Add a VLAN bridge binding selftest") Fixes: 6a414fd ("selftests: rtnetlink: Add an address proto test") Signed-off-by: Wang Liang <[email protected]> Reviewed-by: Hangbin Liu <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
1 parent bd5afca commit 4f86eb0

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

tools/testing/selftests/net/rtnetlink.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1466,6 +1466,8 @@ usage: ${0##*/} OPTS
14661466
EOF
14671467
}
14681468

1469+
require_command jq
1470+
14691471
#check for needed privileges
14701472
if [ "$(id -u)" -ne 0 ];then
14711473
end_test "SKIP: Need root privileges"

tools/testing/selftests/net/vlan_bridge_binding.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,8 @@ test_binding_toggle_off_when_upper_down()
249249
do_test_binding_off : "on->off when upper down"
250250
}
251251

252+
require_command jq
253+
252254
trap defer_scopes_cleanup EXIT
253255
setup_prepare
254256
tests_run

0 commit comments

Comments
 (0)