Skip to content

Commit 5030abc

Browse files
charleskeepaxbroonie
authored andcommitted
ASoC: SDCA: Pull HID and IRQ into the primary SDCA module
If the HID or the IRQ are selected as options they will always require loading alongside the main SDCA module. Since it will never be possible to run without them the value of keeping them as separate modules is fairly limited. Pull them into the main SDCA module to simplify things still further. Signed-off-by: Charles Keepax <[email protected]> Reviewed-by: Arnd Bergmann <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 6894e49 commit 5030abc

File tree

4 files changed

+7
-14
lines changed

4 files changed

+7
-14
lines changed

sound/soc/sdca/Makefile

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,7 @@
11
# SPDX-License-Identifier: GPL-2.0-only
22

33
snd-soc-sdca-y := sdca_functions.o sdca_device.o sdca_regmap.o sdca_asoc.o
4-
snd-soc-sdca-hid-y := sdca_hid.o
5-
snd-soc-sdca-irq-y := sdca_interrupts.o
4+
snd-soc-sdca-$(CONFIG_SND_SOC_SDCA_HID) += sdca_hid.o
5+
snd-soc-sdca-$(CONFIG_SND_SOC_SDCA_IRQ) += sdca_interrupts.o
66

77
obj-$(CONFIG_SND_SOC_SDCA) += snd-soc-sdca.o
8-
ifdef CONFIG_SND_SOC_SDCA_HID
9-
obj-$(CONFIG_SND_SOC_SDCA) += snd-soc-sdca-hid.o
10-
endif
11-
ifdef CONFIG_SND_SOC_SDCA_IRQ
12-
obj-$(CONFIG_SND_SOC_SDCA) += snd-soc-sdca-irq.o
13-
endif

sound/soc/sdca/sdca_functions.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1943,4 +1943,3 @@ EXPORT_SYMBOL_NS(sdca_parse_function, "SND_SOC_SDCA");
19431943

19441944
MODULE_LICENSE("Dual BSD/GPL");
19451945
MODULE_DESCRIPTION("SDCA library");
1946-
MODULE_IMPORT_NS("SND_SOC_SDCA_HID");

sound/soc/sdca/sdca_hid.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ int sdca_add_hid_device(struct device *dev, struct sdca_entity *entity)
121121

122122
return 0;
123123
}
124-
EXPORT_SYMBOL_NS(sdca_add_hid_device, "SND_SOC_SDCA_HID");
124+
EXPORT_SYMBOL_NS(sdca_add_hid_device, "SND_SOC_SDCA");
125125

126126
MODULE_LICENSE("Dual BSD/GPL");
127127
MODULE_DESCRIPTION("SDCA HID library");

sound/soc/sdca/sdca_interrupts.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ int sdca_irq_request(struct device *dev, struct sdca_interrupt_info *info,
279279

280280
return 0;
281281
}
282-
EXPORT_SYMBOL_NS_GPL(sdca_irq_request, "SND_SOC_SDCA_IRQ");
282+
EXPORT_SYMBOL_NS_GPL(sdca_irq_request, "SND_SOC_SDCA");
283283

284284
/**
285285
* sdca_irq_data_populate - Populate common interrupt data
@@ -313,7 +313,7 @@ int sdca_irq_data_populate(struct snd_soc_component *component,
313313

314314
return 0;
315315
}
316-
EXPORT_SYMBOL_NS_GPL(sdca_irq_data_populate, "SND_SOC_SDCA_IRQ");
316+
EXPORT_SYMBOL_NS_GPL(sdca_irq_data_populate, "SND_SOC_SDCA");
317317

318318
/**
319319
* sdca_irq_populate - Request all the individual IRQs for an SDCA Function
@@ -393,7 +393,7 @@ int sdca_irq_populate(struct sdca_function_data *function,
393393

394394
return 0;
395395
}
396-
EXPORT_SYMBOL_NS_GPL(sdca_irq_populate, "SND_SOC_SDCA_IRQ");
396+
EXPORT_SYMBOL_NS_GPL(sdca_irq_populate, "SND_SOC_SDCA");
397397

398398
/**
399399
* sdca_irq_allocate - allocate an SDCA interrupt structure for a device
@@ -433,7 +433,7 @@ struct sdca_interrupt_info *sdca_irq_allocate(struct device *dev,
433433

434434
return info;
435435
}
436-
EXPORT_SYMBOL_NS_GPL(sdca_irq_allocate, "SND_SOC_SDCA_IRQ");
436+
EXPORT_SYMBOL_NS_GPL(sdca_irq_allocate, "SND_SOC_SDCA");
437437

438438
MODULE_LICENSE("GPL");
439439
MODULE_DESCRIPTION("SDCA IRQ library");

0 commit comments

Comments
 (0)