Skip to content

Commit 53abe3e

Browse files
andy-shevtorvalds
authored andcommitted
sched: Remove never used code in mm_cid_get()
Clang is not happy with set but unused variable (this is visible with `make W=1` build: kernel/sched/sched.h:3744:18: error: variable 'cpumask' set but not used [-Werror,-Wunused-but-set-variable] It seems like the variable was never used along with the assignment that does not have side effects as far as I can see. Remove those altogether. Fixes: 223baf9 ("sched: Fix performance regression introduced by mm_cid") Signed-off-by: Andy Shevchenko <[email protected]> Tested-by: Eric Biggers <[email protected]> Reviewed-by: Breno Leitao <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 3d08a42 commit 53abe3e

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

kernel/sched/sched.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3740,11 +3740,9 @@ static inline int mm_cid_get(struct rq *rq, struct task_struct *t,
37403740
struct mm_struct *mm)
37413741
{
37423742
struct mm_cid __percpu *pcpu_cid = mm->pcpu_cid;
3743-
struct cpumask *cpumask;
37443743
int cid;
37453744

37463745
lockdep_assert_rq_held(rq);
3747-
cpumask = mm_cidmask(mm);
37483746
cid = __this_cpu_read(pcpu_cid->cid);
37493747
if (mm_cid_is_valid(cid)) {
37503748
mm_cid_snapshot_time(rq, mm);

0 commit comments

Comments
 (0)