devlink: introduce a helper for netlink multicast send

Jiri Pirko · Paolo Abeni · commit 5648de0b1f2b · 2023-12-19T15:31:40.000+01:00
Introduce a helper devlink_nl_notify_send() so each object notification
function does not have to call genlmsg_multicast_netns() with the same
arguments.

Signed-off-by: Jiri Pirko &lt;jiri@nvidia.com&gt;
Signed-off-by: Paolo Abeni &lt;pabeni@redhat.com&gt;
diff --git a/net/devlink/dev.c b/net/devlink/dev.c
@@ -217,8 +217,7 @@ static void devlink_notify(struct devlink *devlink, enum devlink_command cmd)
 		return;
 	}
 
-	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),
-				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
+	devlink_nl_notify_send(devlink, msg);
 }
 
 int devlink_nl_get_doit(struct sk_buff *skb, struct genl_info *info)
@@ -1013,8 +1012,7 @@ static void __devlink_flash_update_notify(struct devlink *devlink,
 	if (err)
 		goto out_free_msg;
 
-	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),
-				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
+	devlink_nl_notify_send(devlink, msg);
 	return;
 
 out_free_msg:
diff --git a/net/devlink/devl_internal.h b/net/devlink/devl_internal.h
@@ -191,6 +191,13 @@ static inline bool devlink_nl_notify_need(struct devlink *devlink)
 				  DEVLINK_MCGRP_CONFIG);
 }
 
+static inline void devlink_nl_notify_send(struct devlink *devlink,
+					  struct sk_buff *msg)
+{
+	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),
+				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
+}
+
 /* Notify */
 void devlink_notify_register(struct devlink *devlink);
 void devlink_notify_unregister(struct devlink *devlink);
diff --git a/net/devlink/health.c b/net/devlink/health.c
@@ -509,8 +509,7 @@ static void devlink_recover_notify(struct devlink_health_reporter *reporter,
 		return;
 	}
 
-	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,
-				0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
+	devlink_nl_notify_send(devlink, msg);
 }
 
 void
diff --git a/net/devlink/linecard.c b/net/devlink/linecard.c
@@ -150,8 +150,7 @@ static void devlink_linecard_notify(struct devlink_linecard *linecard,
 		return;
 	}
 
-	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),
-				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
+	devlink_nl_notify_send(devlink, msg);
 }
 
 void devlink_linecards_notify_register(struct devlink *devlink)
diff --git a/net/devlink/param.c b/net/devlink/param.c
@@ -356,8 +356,7 @@ static void devlink_param_notify(struct devlink *devlink,
 		return;
 	}
 
-	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),
-				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
+	devlink_nl_notify_send(devlink, msg);
 }
 
 static void devlink_params_notify(struct devlink *devlink,
diff --git a/net/devlink/port.c b/net/devlink/port.c
@@ -525,8 +525,7 @@ static void devlink_port_notify(struct devlink_port *devlink_port,
 		return;
 	}
 
-	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,
-				0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
+	devlink_nl_notify_send(devlink, msg);
 }
 
 static void devlink_ports_notify(struct devlink *devlink,
diff --git a/net/devlink/rate.c b/net/devlink/rate.c
@@ -159,8 +159,7 @@ static void devlink_rate_notify(struct devlink_rate *devlink_rate,
 		return;
 	}
 
-	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,
-				0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
+	devlink_nl_notify_send(devlink, msg);
 }
 
 void devlink_rates_notify_register(struct devlink *devlink)
diff --git a/net/devlink/region.c b/net/devlink/region.c
@@ -242,8 +242,7 @@ static void devlink_nl_region_notify(struct devlink_region *region,
 	if (IS_ERR(msg))
 		return;
 
-	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,
-				0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
+	devlink_nl_notify_send(devlink, msg);
 }
 
 void devlink_regions_notify_register(struct devlink *devlink)
diff --git a/net/devlink/trap.c b/net/devlink/trap.c
@@ -1188,8 +1188,7 @@ devlink_trap_group_notify(struct devlink *devlink,
 		return;
 	}
 
-	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),
-				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
+	devlink_nl_notify_send(devlink, msg);
 }
 
 void devlink_trap_groups_notify_register(struct devlink *devlink)
@@ -1249,8 +1248,7 @@ static void devlink_trap_notify(struct devlink *devlink,
 		return;
 	}
 
-	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),
-				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
+	devlink_nl_notify_send(devlink, msg);
 }
 
 void devlink_traps_notify_register(struct devlink *devlink)
@@ -1727,8 +1725,7 @@ devlink_trap_policer_notify(struct devlink *devlink,
 		return;
 	}
 
-	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),
-				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
+	devlink_nl_notify_send(devlink, msg);
 }
 
 void devlink_trap_policers_notify_register(struct devlink *devlink)

Original file line number	Diff line number	Diff line change
`@@ -509,8 +509,7 @@ static void devlink_recover_notify(struct devlink_health_reporter *reporter,`
`509`	`509`	`return;`
`510`	`510`	`}`
`511`	`511`
`512`		`- genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,`
`513`		`- 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);`
	`512`	`+ devlink_nl_notify_send(devlink, msg);`
`514`	`513`	`}`
`515`	`514`
`516`	`515`	`void`
Original file line number	Diff line number	Diff line change
`@@ -150,8 +150,7 @@ static void devlink_linecard_notify(struct devlink_linecard *linecard,`
`150`	`150`	`return;`
`151`	`151`	`}`
`152`	`152`
`153`		`- genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),`
`154`		`- msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);`
	`153`	`+ devlink_nl_notify_send(devlink, msg);`
`155`	`154`	`}`
`156`	`155`
`157`	`156`	`void devlink_linecards_notify_register(struct devlink *devlink)`
Original file line number	Diff line number	Diff line change
`@@ -356,8 +356,7 @@ static void devlink_param_notify(struct devlink *devlink,`
`356`	`356`	`return;`
`357`	`357`	`}`
`358`	`358`
`359`		`- genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),`
`360`		`- msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);`
	`359`	`+ devlink_nl_notify_send(devlink, msg);`
`361`	`360`	`}`
`362`	`361`
`363`	`362`	`static void devlink_params_notify(struct devlink *devlink,`
Original file line number	Diff line number	Diff line change
`@@ -525,8 +525,7 @@ static void devlink_port_notify(struct devlink_port *devlink_port,`
`525`	`525`	`return;`
`526`	`526`	`}`
`527`	`527`
`528`		`- genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,`
`529`		`- 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);`
	`528`	`+ devlink_nl_notify_send(devlink, msg);`
`530`	`529`	`}`
`531`	`530`
`532`	`531`	`static void devlink_ports_notify(struct devlink *devlink,`
Original file line number	Diff line number	Diff line change
`@@ -159,8 +159,7 @@ static void devlink_rate_notify(struct devlink_rate *devlink_rate,`
`159`	`159`	`return;`
`160`	`160`	`}`
`161`	`161`
`162`		`- genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,`
`163`		`- 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);`
	`162`	`+ devlink_nl_notify_send(devlink, msg);`
`164`	`163`	`}`
`165`	`164`
`166`	`165`	`void devlink_rates_notify_register(struct devlink *devlink)`
Original file line number	Diff line number	Diff line change
`@@ -242,8 +242,7 @@ static void devlink_nl_region_notify(struct devlink_region *region,`
`242`	`242`	`if (IS_ERR(msg))`
`243`	`243`	`return;`
`244`	`244`
`245`		`- genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), msg,`
`246`		`- 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);`
	`245`	`+ devlink_nl_notify_send(devlink, msg);`
`247`	`246`	`}`
`248`	`247`
`249`	`248`	`void devlink_regions_notify_register(struct devlink *devlink)`
Original file line number	Diff line number	Diff line change
`@@ -1188,8 +1188,7 @@ devlink_trap_group_notify(struct devlink *devlink,`
`1188`	`1188`	`return;`
`1189`	`1189`	`}`
`1190`	`1190`
`1191`		`- genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),`
`1192`		`- msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);`
	`1191`	`+ devlink_nl_notify_send(devlink, msg);`
`1193`	`1192`	`}`
`1194`	`1193`
`1195`	`1194`	`void devlink_trap_groups_notify_register(struct devlink *devlink)`
`@@ -1249,8 +1248,7 @@ static void devlink_trap_notify(struct devlink *devlink,`
`1249`	`1248`	`return;`
`1250`	`1249`	`}`
`1251`	`1250`
`1252`		`- genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),`
`1253`		`- msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);`
	`1251`	`+ devlink_nl_notify_send(devlink, msg);`
`1254`	`1252`	`}`
`1255`	`1253`
`1256`	`1254`	`void devlink_traps_notify_register(struct devlink *devlink)`
`@@ -1727,8 +1725,7 @@ devlink_trap_policer_notify(struct devlink *devlink,`
`1727`	`1725`	`return;`
`1728`	`1726`	`}`
`1729`	`1727`
`1730`		`- genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),`
`1731`		`- msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);`
	`1728`	`+ devlink_nl_notify_send(devlink, msg);`
`1732`	`1729`	`}`
`1733`	`1730`
`1734`	`1731`	`void devlink_trap_policers_notify_register(struct devlink *devlink)`