Skip to content

Commit 576fca0

Browse files
author
Steven Price
committed
drm/panthor: Wait for _READY register when powering on
panthor_gpu_block_power_on() takes a register offset (rdy_reg) for the purpose of waiting for the power transition to complete. However, a copy/paste error converting to use the new 64 register functions switched it to using the pwrtrans_reg register instead. Fix the function to use the correct register. Fixes: 4d230aa ("drm/panthor: Add 64-bit and poll register accessors") Signed-off-by: Steven Price <[email protected]> Reviewed-by: Liviu Dudau <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 4dfed55 commit 576fca0

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/panthor/panthor_gpu.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,9 @@ int panthor_gpu_block_power_on(struct panthor_device *ptdev,
297297

298298
gpu_write64(ptdev, pwron_reg, mask);
299299

300-
ret = gpu_read64_relaxed_poll_timeout(ptdev, pwrtrans_reg, val,
301-
!(mask & val), 100, timeout_us);
300+
ret = gpu_read64_relaxed_poll_timeout(ptdev, rdy_reg, val,
301+
(mask & val) == val,
302+
100, timeout_us);
302303
if (ret) {
303304
drm_err(&ptdev->base, "timeout waiting on %s:%llx readiness",
304305
blk_name, mask);

0 commit comments

Comments
 (0)