Skip to content

Commit 5b81d59

Browse files
committed
Merge branch 'mlx5-misc-fixes-2025-07-10'
Tariq Toukan says: ==================== mlx5 misc fixes 2025-07-10 This small patchset provides misc bug fixes from the team to the mlx5 core and EN drivers. ==================== Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
2 parents 71b976d + 4c9fce5 commit 5b81d59

File tree

5 files changed

+20
-9
lines changed

5 files changed

+20
-9
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en/fs.h

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ enum {
1818

1919
enum {
2020
MLX5E_TC_PRIO = 0,
21-
MLX5E_NIC_PRIO
21+
MLX5E_PROMISC_PRIO,
22+
MLX5E_NIC_PRIO,
2223
};
2324

2425
struct mlx5e_flow_table {
@@ -68,9 +69,13 @@ struct mlx5e_l2_table {
6869
MLX5_HASH_FIELD_SEL_DST_IP |\
6970
MLX5_HASH_FIELD_SEL_IPSEC_SPI)
7071

71-
/* NIC prio FTS */
72+
/* NIC promisc FT level */
7273
enum {
7374
MLX5E_PROMISC_FT_LEVEL,
75+
};
76+
77+
/* NIC prio FTS */
78+
enum {
7479
MLX5E_VLAN_FT_LEVEL,
7580
MLX5E_L2_FT_LEVEL,
7681
MLX5E_TTC_FT_LEVEL,

drivers/net/ethernet/mellanox/mlx5/core/en_dim.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ int mlx5e_dim_rx_change(struct mlx5e_rq *rq, bool enable)
113113
__set_bit(MLX5E_RQ_STATE_DIM, &rq->state);
114114
} else {
115115
__clear_bit(MLX5E_RQ_STATE_DIM, &rq->state);
116-
116+
synchronize_net();
117117
mlx5e_dim_disable(rq->dim);
118118
rq->dim = NULL;
119119
}
@@ -140,7 +140,7 @@ int mlx5e_dim_tx_change(struct mlx5e_txqsq *sq, bool enable)
140140
__set_bit(MLX5E_SQ_STATE_DIM, &sq->state);
141141
} else {
142142
__clear_bit(MLX5E_SQ_STATE_DIM, &sq->state);
143-
143+
synchronize_net();
144144
mlx5e_dim_disable(sq->dim);
145145
sq->dim = NULL;
146146
}

drivers/net/ethernet/mellanox/mlx5/core/en_fs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -780,7 +780,7 @@ static int mlx5e_create_promisc_table(struct mlx5e_flow_steering *fs)
780780
ft_attr.max_fte = MLX5E_PROMISC_TABLE_SIZE;
781781
ft_attr.autogroup.max_num_groups = 1;
782782
ft_attr.level = MLX5E_PROMISC_FT_LEVEL;
783-
ft_attr.prio = MLX5E_NIC_PRIO;
783+
ft_attr.prio = MLX5E_PROMISC_PRIO;
784784

785785
ft->t = mlx5_create_auto_grouped_flow_table(fs->ns, &ft_attr);
786786
if (IS_ERR(ft->t)) {

drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1076,6 +1076,7 @@ static int esw_qos_vports_node_update_parent(struct mlx5_esw_sched_node *node,
10761076
return err;
10771077
}
10781078
esw_qos_node_set_parent(node, parent);
1079+
node->bw_share = 0;
10791080

10801081
return 0;
10811082
}

drivers/net/ethernet/mellanox/mlx5/core/fs_core.c

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,16 @@
113113
#define ETHTOOL_PRIO_NUM_LEVELS 1
114114
#define ETHTOOL_NUM_PRIOS 11
115115
#define ETHTOOL_MIN_LEVEL (KERNEL_MIN_LEVEL + ETHTOOL_NUM_PRIOS)
116-
/* Promiscuous, Vlan, mac, ttc, inner ttc, {UDP/ANY/aRFS/accel/{esp, esp_err}}, IPsec policy,
116+
/* Vlan, mac, ttc, inner ttc, {UDP/ANY/aRFS/accel/{esp, esp_err}}, IPsec policy,
117117
* {IPsec RoCE MPV,Alias table},IPsec RoCE policy
118118
*/
119-
#define KERNEL_NIC_PRIO_NUM_LEVELS 11
119+
#define KERNEL_NIC_PRIO_NUM_LEVELS 10
120120
#define KERNEL_NIC_NUM_PRIOS 1
121-
/* One more level for tc */
122-
#define KERNEL_MIN_LEVEL (KERNEL_NIC_PRIO_NUM_LEVELS + 1)
121+
/* One more level for tc, and one more for promisc */
122+
#define KERNEL_MIN_LEVEL (KERNEL_NIC_PRIO_NUM_LEVELS + 2)
123+
124+
#define KERNEL_NIC_PROMISC_NUM_PRIOS 1
125+
#define KERNEL_NIC_PROMISC_NUM_LEVELS 1
123126

124127
#define KERNEL_NIC_TC_NUM_PRIOS 1
125128
#define KERNEL_NIC_TC_NUM_LEVELS 3
@@ -187,6 +190,8 @@ static struct init_tree_node {
187190
ADD_NS(MLX5_FLOW_TABLE_MISS_ACTION_DEF,
188191
ADD_MULTIPLE_PRIO(KERNEL_NIC_TC_NUM_PRIOS,
189192
KERNEL_NIC_TC_NUM_LEVELS),
193+
ADD_MULTIPLE_PRIO(KERNEL_NIC_PROMISC_NUM_PRIOS,
194+
KERNEL_NIC_PROMISC_NUM_LEVELS),
190195
ADD_MULTIPLE_PRIO(KERNEL_NIC_NUM_PRIOS,
191196
KERNEL_NIC_PRIO_NUM_LEVELS))),
192197
ADD_PRIO(0, BY_PASS_MIN_LEVEL, 0, FS_CHAINING_CAPS,

0 commit comments

Comments
 (0)