Skip to content

Commit 5e91879

Browse files
Xichao Zhaokuba-moo
authored andcommitted
net: dsa: Remove the use of dev_err_probe()
The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore, remove the useless call to dev_err_probe(), and just return the value instead. Signed-off-by: Xichao Zhao <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent ed1e7e2 commit 5e91879

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/net/dsa/lantiq_gswip.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1935,8 +1935,7 @@ static int gswip_gphy_fw_load(struct gswip_priv *priv, struct gswip_gphy_fw *gph
19351935
memcpy(fw_addr, fw->data, fw->size);
19361936
} else {
19371937
release_firmware(fw);
1938-
return dev_err_probe(dev, -ENOMEM,
1939-
"failed to alloc firmware memory\n");
1938+
return -ENOMEM;
19401939
}
19411940

19421941
release_firmware(fw);

0 commit comments

Comments
 (0)