Skip to content

Commit 61a5a3f

Browse files
committed
drm/xe: Annotate default for guc_log_level param
Reword the parameter description so it's clear what's the default and what are the verbose levels. Reviewed-by: John Harrison <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lucas De Marchi <[email protected]>
1 parent a37128b commit 61a5a3f

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

drivers/gpu/drm/xe/xe_module.c

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,15 @@
1818
#include "xe_observation.h"
1919
#include "xe_sched_job.h"
2020

21+
#if IS_ENABLED(CONFIG_DRM_XE_DEBUG)
22+
#define DEFAULT_GUC_LOG_LEVEL 3
23+
#else
24+
#define DEFAULT_GUC_LOG_LEVEL 1
25+
#endif
26+
2127
struct xe_modparam xe_modparam = {
2228
.probe_display = true,
23-
.guc_log_level = IS_ENABLED(CONFIG_DRM_XE_DEBUG) ? 3 : 1,
29+
.guc_log_level = DEFAULT_GUC_LOG_LEVEL,
2430
.force_probe = CONFIG_DRM_XE_FORCE_PROBE,
2531
.wedged_mode = 1,
2632
.svm_notifier_size = 512,
@@ -40,7 +46,8 @@ module_param_named(vram_bar_size, xe_modparam.force_vram_bar_size, int, 0600);
4046
MODULE_PARM_DESC(vram_bar_size, "Set the vram bar size (in MiB) - <0=disable-resize, 0=max-needed-size[default], >0=force-size");
4147

4248
module_param_named(guc_log_level, xe_modparam.guc_log_level, int, 0600);
43-
MODULE_PARM_DESC(guc_log_level, "GuC firmware logging level (0=disable, 1..5=enable with verbosity min..max)");
49+
MODULE_PARM_DESC(guc_log_level, "GuC firmware logging level (0=disable, 1=normal, 2..5=verbose-levels "
50+
"[default=" __stringify(DEFAULT_GUC_LOG_LEVEL) "])");
4451

4552
module_param_named_unsafe(guc_firmware_path, xe_modparam.guc_firmware_path, charp, 0400);
4653
MODULE_PARM_DESC(guc_firmware_path,

0 commit comments

Comments
 (0)