Skip to content

Commit 64e2f60

Browse files
committed
s390: Disable ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP
As reported by Luiz Capitulino enabling HVO on s390 leads to reproducible crashes. The problem is that kernel page tables are modified without flushing corresponding TLB entries. Even if it looks like the empty flush_tlb_all() implementation on s390 is the problem, it is actually a different problem: on s390 it is not allowed to replace an active/valid page table entry with another valid page table entry without the detour over an invalid entry. A direct replacement may lead to random crashes and/or data corruption. In order to invalidate an entry special instructions have to be used (e.g. ipte or idte). Alternatively there are also special instructions available which allow to replace a valid entry with a different valid entry (e.g. crdte or cspg). Given that the HVO code currently does not provide the hooks to allow for an implementation which is compliant with the s390 architecture requirements, disable ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP again, which is basically a revert of the original patch which enabled it. Reported-by: Luiz Capitulino <[email protected]> Closes: https://lore.kernel.org/all/[email protected]/ Fixes: 00a34d5 ("s390: select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP") Cc: [email protected] Tested-by: Luiz Capitulino <[email protected]> Reviewed-by: Gerald Schaefer <[email protected]> Reviewed-by: David Hildenbrand <[email protected]> Signed-off-by: Heiko Carstens <[email protected]>
1 parent 07ad45e commit 64e2f60

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

arch/s390/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@ config S390
158158
select ARCH_WANT_IRQS_OFF_ACTIVATE_MM
159159
select ARCH_WANT_KERNEL_PMD_MKWRITE
160160
select ARCH_WANT_LD_ORPHAN_WARN
161-
select ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP
162161
select ARCH_WANTS_THP_SWAP
163162
select BUILDTIME_TABLE_SORT
164163
select CLONE_BACKWARDS2

0 commit comments

Comments
 (0)