Skip to content

Commit 66cdf05

Browse files
mwalletomba
authored andcommitted
drm/tidss: encoder: convert to devm_drm_bridge_alloc()
Convert the tidss encoder to use devm_drm_bridge_alloc(). Instead of allocating the memory by drmm_simple_encoder_alloc() use devm_drm_bridge_alloc() and initialize the encoder afterwards. Fixes: a7748dd ("drm/bridge: get/put the bridge reference in drm_bridge_add/remove()") Signed-off-by: Michael Walle <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Tomi Valkeinen <[email protected]>
1 parent fe69a39 commit 66cdf05

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

drivers/gpu/drm/tidss/tidss_encoder.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,14 +90,18 @@ int tidss_encoder_create(struct tidss_device *tidss,
9090
struct drm_connector *connector;
9191
int ret;
9292

93-
t_enc = drmm_simple_encoder_alloc(&tidss->ddev, struct tidss_encoder,
94-
encoder, encoder_type);
93+
t_enc = devm_drm_bridge_alloc(tidss->dev, struct tidss_encoder,
94+
bridge, &tidss_bridge_funcs);
9595
if (IS_ERR(t_enc))
9696
return PTR_ERR(t_enc);
9797

98+
ret = drm_simple_encoder_init(&tidss->ddev, &t_enc->encoder,
99+
encoder_type);
100+
if (ret)
101+
return ret;
102+
98103
t_enc->tidss = tidss;
99104
t_enc->next_bridge = next_bridge;
100-
t_enc->bridge.funcs = &tidss_bridge_funcs;
101105

102106
enc = &t_enc->encoder;
103107
enc->possible_crtcs = possible_crtcs;

0 commit comments

Comments
 (0)