Skip to content

Commit 6d891d2

Browse files
committed
drm/xe/lrc: Remove leftover TODO/FIXME
There isn't anything to set for CTX_TIMESTAMP handling in the empty LRC: that is set on every LRC init since it should always start from 0 rather than the value saved in the image after first submission. The FIXME about perma-pinning also doesn't make much sense as we will always going to pin the lrc and the GGTT mapping has nothing to do with VM bind. Nuke these leftover comments. Reviewed-by: Matthew Brost <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lucas De Marchi <[email protected]>
1 parent fab2cc0 commit 6d891d2

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/gpu/drm/xe/xe_lrc.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -589,8 +589,6 @@ static void set_context_control(u32 *regs, struct xe_hw_engine *hwe)
589589
if (xe_gt_has_indirect_ring_state(hwe->gt))
590590
regs[CTX_CONTEXT_CONTROL] |=
591591
_MASKED_BIT_ENABLE(CTX_CTRL_INDIRECT_RING_STATE_ENABLE);
592-
593-
/* TODO: Timestamp */
594592
}
595593

596594
static void set_memory_based_intr(u32 *regs, struct xe_hw_engine *hwe)
@@ -1181,10 +1179,6 @@ static int xe_lrc_init(struct xe_lrc *lrc, struct xe_hw_engine *hwe,
11811179
if (vm && vm->xef) /* userspace */
11821180
bo_flags |= XE_BO_FLAG_PINNED_LATE_RESTORE;
11831181

1184-
/*
1185-
* FIXME: Perma-pinning LRC as we don't yet support moving GGTT address
1186-
* via VM bind calls.
1187-
*/
11881182
lrc->bo = xe_bo_create_pin_map(xe, tile, NULL, bo_size,
11891183
ttm_bo_type_kernel,
11901184
bo_flags);

0 commit comments

Comments
 (0)