Skip to content

Commit 711f19d

Browse files
Quanmin Yanakpm00
authored andcommitted
mm/damon/lru_sort: avoid divide-by-zero in damon_lru_sort_apply_parameters()
Patch series "mm/damon: avoid divide-by-zero in DAMON module's parameters application". DAMON's RECLAIM and LRU_SORT modules perform no validation on user-configured parameters during application, which may lead to division-by-zero errors. Avoid the divide-by-zero by adding validation checks when DAMON modules attempt to apply the parameters. This patch (of 2): During the calculation of 'hot_thres' and 'cold_thres', either 'sample_interval' or 'aggr_interval' is used as the divisor, which may lead to division-by-zero errors. Fix it by directly returning -EINVAL when such a case occurs. Additionally, since 'aggr_interval' is already required to be set no smaller than 'sample_interval' in damon_set_attrs(), only the case where 'sample_interval' is zero needs to be checked. Link: https://lkml.kernel.org/r/[email protected] Fixes: 40e983c ("mm/damon: introduce DAMON-based LRU-lists Sorting") Signed-off-by: Quanmin Yan <[email protected]> Reviewed-by: SeongJae Park <[email protected]> Cc: Kefeng Wang <[email protected]> Cc: ze zuo <[email protected]> Cc: <[email protected]> [6.0+] Signed-off-by: Andrew Morton <[email protected]>
1 parent ce652aa commit 711f19d

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

mm/damon/lru_sort.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,11 @@ static int damon_lru_sort_apply_parameters(void)
198198
if (err)
199199
return err;
200200

201+
if (!damon_lru_sort_mon_attrs.sample_interval) {
202+
err = -EINVAL;
203+
goto out;
204+
}
205+
201206
err = damon_set_attrs(ctx, &damon_lru_sort_mon_attrs);
202207
if (err)
203208
goto out;

0 commit comments

Comments
 (0)