Skip to content

Commit 7557f18

Browse files
KRIISHSHARMAgregkh
authored andcommitted
binder: Fix missing kernel-doc entries in binder.c
Fix several kernel-doc warnings in `drivers/android/binder.c` caused by undocumented struct members and function parameters. In particular, add missing documentation for the `@thread` parameter in binder_free_buf_locked(). Signed-off-by: Kriish Sharma <[email protected]> Acked-by: Carlos Llamas <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent b5ce7a5 commit 7557f18

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

drivers/android/binder.c

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2418,10 +2418,10 @@ static int binder_translate_fd(u32 fd, binder_size_t fd_offset,
24182418

24192419
/**
24202420
* struct binder_ptr_fixup - data to be fixed-up in target buffer
2421-
* @offset offset in target buffer to fixup
2422-
* @skip_size bytes to skip in copy (fixup will be written later)
2423-
* @fixup_data data to write at fixup offset
2424-
* @node list node
2421+
* @offset: offset in target buffer to fixup
2422+
* @skip_size: bytes to skip in copy (fixup will be written later)
2423+
* @fixup_data: data to write at fixup offset
2424+
* @node: list node
24252425
*
24262426
* This is used for the pointer fixup list (pf) which is created and consumed
24272427
* during binder_transaction() and is only accessed locally. No
@@ -2438,10 +2438,10 @@ struct binder_ptr_fixup {
24382438

24392439
/**
24402440
* struct binder_sg_copy - scatter-gather data to be copied
2441-
* @offset offset in target buffer
2442-
* @sender_uaddr user address in source buffer
2443-
* @length bytes to copy
2444-
* @node list node
2441+
* @offset: offset in target buffer
2442+
* @sender_uaddr: user address in source buffer
2443+
* @length: bytes to copy
2444+
* @node: list node
24452445
*
24462446
* This is used for the sg copy list (sgc) which is created and consumed
24472447
* during binder_transaction() and is only accessed locally. No
@@ -4063,14 +4063,15 @@ binder_freeze_notification_done(struct binder_proc *proc,
40634063

40644064
/**
40654065
* binder_free_buf() - free the specified buffer
4066-
* @proc: binder proc that owns buffer
4067-
* @buffer: buffer to be freed
4068-
* @is_failure: failed to send transaction
4066+
* @proc: binder proc that owns buffer
4067+
* @thread: binder thread performing the buffer release
4068+
* @buffer: buffer to be freed
4069+
* @is_failure: failed to send transaction
40694070
*
4070-
* If buffer for an async transaction, enqueue the next async
4071+
* If the buffer is for an async transaction, enqueue the next async
40714072
* transaction from the node.
40724073
*
4073-
* Cleanup buffer and free it.
4074+
* Cleanup the buffer and free it.
40744075
*/
40754076
static void
40764077
binder_free_buf(struct binder_proc *proc,

0 commit comments

Comments
 (0)