Skip to content

Commit 7933a58

Browse files
seong-gwang-heobrauner
authored andcommitted
ovl: remove redundant IOCB_DIO_CALLER_COMP clearing
The backing_file_write_iter() function, which is called immediately after this code, already contains identical logic to clear the IOCB_DIO_CALLER_COMP flag along with the same explanatory comment. There is no need to duplicate this operation in the overlayfs code. Signed-off-by: Seong-Gwang Heo <[email protected]> Fixes: a6293b3 ("fs: factor out backing_file_{read,write}_iter() helpers") Acked-by: Miklos Szeredi <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Signed-off-by: Christian Brauner <[email protected]>
1 parent b279628 commit 7933a58

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

fs/overlayfs/file.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -369,11 +369,6 @@ static ssize_t ovl_write_iter(struct kiocb *iocb, struct iov_iter *iter)
369369
if (!ovl_should_sync(OVL_FS(inode->i_sb)))
370370
ifl &= ~(IOCB_DSYNC | IOCB_SYNC);
371371

372-
/*
373-
* Overlayfs doesn't support deferred completions, don't copy
374-
* this property in case it is set by the issuer.
375-
*/
376-
ifl &= ~IOCB_DIO_CALLER_COMP;
377372
ret = backing_file_write_iter(realfile, iter, iocb, ifl, &ctx);
378373

379374
out_unlock:

0 commit comments

Comments
 (0)