Skip to content

Commit 7bcd032

Browse files
rddunlapij-intel
authored andcommitted
platform/x86: intel_ips: fix kernel-doc formatting
Fix kernel-doc function notation and comment formatting to prevent warnings from scripts/kernel-doc. for drivers/platform/x86/intel_ips.c: 595: warning: No description found for return value of 'mcp_exceeded' 624: warning: No description found for return value of 'cpu_exceeded' 650: warning: No description found for return value of 'mch_exceeded' 745: warning: bad line: cpu+ gpu+ cpu+gpu- cpu-gpu+ cpu-gpu- 746: warning: bad line: cpu < gpu < cpu+gpu+ cpu+ gpu+ nothing 753: warning: No description found for return value of 'ips_adjust' 747: warning: bad line: cpu < gpu >= cpu+gpu-(mcp<) cpu+gpu-(mcp<) gpu- gpu- 748: warning: bad line: cpu >= gpu < cpu-gpu+(mcp<) cpu- cpu-gpu+(mcp<) cpu- 749: warning: bad line: cpu >= gpu >= cpu-gpu- cpu-gpu- cpu-gpu- cpu-gpu- 945: warning: No description found for return value of 'ips_monitor' 1151: warning: No description found for return value of 'ips_irq_handler' 1301: warning: Function parameter or member 'ips' not described in 'ips_detect_cpu' 1302: warning: No description found for return value of 'ips_detect_cpu' 1358: warning: No description found for return value of 'ips_get_i915_syms' Signed-off-by: Randy Dunlap <[email protected]> Cc: Hans de Goede <[email protected]> Cc: Ilpo Järvinen <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Ilpo Järvinen <[email protected]> Signed-off-by: Ilpo Järvinen <[email protected]>
1 parent 17fe3ec commit 7bcd032

File tree

1 file changed

+23
-7
lines changed

1 file changed

+23
-7
lines changed

drivers/platform/x86/intel_ips.c

Lines changed: 23 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -590,6 +590,8 @@ static void ips_disable_gpu_turbo(struct ips_driver *ips)
590590
* @ips: IPS driver struct
591591
*
592592
* Check whether the MCP is over its thermal or power budget.
593+
*
594+
* Returns: %true if the temp or power has exceeded its maximum, else %false
593595
*/
594596
static bool mcp_exceeded(struct ips_driver *ips)
595597
{
@@ -619,6 +621,8 @@ static bool mcp_exceeded(struct ips_driver *ips)
619621
* @cpu: CPU number to check
620622
*
621623
* Check a given CPU's average temp or power is over its limit.
624+
*
625+
* Returns: %true if the temp or power has exceeded its maximum, else %false
622626
*/
623627
static bool cpu_exceeded(struct ips_driver *ips, int cpu)
624628
{
@@ -645,6 +649,8 @@ static bool cpu_exceeded(struct ips_driver *ips, int cpu)
645649
* @ips: IPS driver struct
646650
*
647651
* Check the MCH temp & power against their maximums.
652+
*
653+
* Returns: %true if the temp or power has exceeded its maximum, else %false
648654
*/
649655
static bool mch_exceeded(struct ips_driver *ips)
650656
{
@@ -742,12 +748,13 @@ static void update_turbo_limits(struct ips_driver *ips)
742748
* - down (at TDP limit)
743749
* - adjust both CPU and GPU down if possible
744750
*
745-
cpu+ gpu+ cpu+gpu- cpu-gpu+ cpu-gpu-
746-
cpu < gpu < cpu+gpu+ cpu+ gpu+ nothing
747-
cpu < gpu >= cpu+gpu-(mcp<) cpu+gpu-(mcp<) gpu- gpu-
748-
cpu >= gpu < cpu-gpu+(mcp<) cpu- cpu-gpu+(mcp<) cpu-
749-
cpu >= gpu >= cpu-gpu- cpu-gpu- cpu-gpu- cpu-gpu-
751+
* |cpu+ gpu+ cpu+gpu- cpu-gpu+ cpu-gpu-
752+
* cpu < gpu < |cpu+gpu+ cpu+ gpu+ nothing
753+
* cpu < gpu >= |cpu+gpu-(mcp<) cpu+gpu-(mcp<) gpu- gpu-
754+
* cpu >= gpu < |cpu-gpu+(mcp<) cpu- cpu-gpu+(mcp<) cpu-
755+
* cpu >= gpu >=|cpu-gpu- cpu-gpu- cpu-gpu- cpu-gpu-
750756
*
757+
* Returns: %0
751758
*/
752759
static int ips_adjust(void *data)
753760
{
@@ -935,11 +942,13 @@ static void monitor_timeout(struct timer_list *t)
935942
* @data: ips driver structure
936943
*
937944
* This is the main function for the IPS driver. It monitors power and
938-
* tempurature in the MCP and adjusts CPU and GPU power clams accordingly.
945+
* temperature in the MCP and adjusts CPU and GPU power clamps accordingly.
939946
*
940-
* We keep a 5s moving average of power consumption and tempurature. Using
947+
* We keep a 5s moving average of power consumption and temperature. Using
941948
* that data, along with CPU vs GPU preference, we adjust the power clamps
942949
* up or down.
950+
*
951+
* Returns: %0 on success or -errno on error
943952
*/
944953
static int ips_monitor(void *data)
945954
{
@@ -1146,6 +1155,8 @@ static void dump_thermal_info(struct ips_driver *ips)
11461155
* Handle temperature limit trigger events, generally by lowering the clamps.
11471156
* If we're at a critical limit, we clamp back to the lowest possible value
11481157
* to prevent emergency shutdown.
1158+
*
1159+
* Returns: IRQ_NONE or IRQ_HANDLED
11491160
*/
11501161
static irqreturn_t ips_irq_handler(int irq, void *arg)
11511162
{
@@ -1293,9 +1304,12 @@ static void ips_debugfs_init(struct ips_driver *ips)
12931304

12941305
/**
12951306
* ips_detect_cpu - detect whether CPU supports IPS
1307+
* @ips: IPS driver struct
12961308
*
12971309
* Walk our list and see if we're on a supported CPU. If we find one,
12981310
* return the limits for it.
1311+
*
1312+
* Returns: the &ips_mcp_limits struct that matches the boot CPU or %NULL
12991313
*/
13001314
static struct ips_mcp_limits *ips_detect_cpu(struct ips_driver *ips)
13011315
{
@@ -1352,6 +1366,8 @@ static struct ips_mcp_limits *ips_detect_cpu(struct ips_driver *ips)
13521366
* monitor and control graphics turbo mode. If we can find them, we can
13531367
* enable graphics turbo, otherwise we must disable it to avoid exceeding
13541368
* thermal and power limits in the MCP.
1369+
*
1370+
* Returns: %true if the required symbols are found, else %false
13551371
*/
13561372
static bool ips_get_i915_syms(struct ips_driver *ips)
13571373
{

0 commit comments

Comments
 (0)