Skip to content

Commit 7e35fc7

Browse files
author
Thomas Zimmermann
committed
video: Make CONFIG_FIRMWARE_EDID generally available
DRM drivers such as efidrm and vesadrm can export firmware EDID data to userspace. Make the related option CONFIG_FIRMWARE_EDID available without CONFIG_FB. Make it depend on X86, which is currently the only architecture providing EDID information. Signed-off-by: Thomas Zimmermann <[email protected]> Reviewed-by: Helge Deller <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 629c1a9 commit 7e35fc7

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

drivers/video/Kconfig

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,23 @@ config HDMI
6161

6262
endif # HAS_IOMEM
6363

64+
config FIRMWARE_EDID
65+
bool "Enable firmware EDID"
66+
depends on X86
67+
help
68+
This enables access to the EDID transferred from the firmware.
69+
On x86, this is from the VESA BIOS. DRM display drivers will
70+
be able to export the information to userspace.
71+
72+
Also enable this if DDC/I2C transfers do not work for your driver
73+
and if you are using nvidiafb, i810fb or savagefb.
74+
75+
In general, choosing Y for this option is safe. If you
76+
experience extremely long delays while booting before you get
77+
something on your display, try setting this to N. Matrox cards in
78+
combination with certain motherboards and monitors are known to
79+
suffer from this problem.
80+
6481
if VT
6582
source "drivers/video/console/Kconfig"
6683
endif
@@ -70,5 +87,4 @@ if FB_CORE || SGI_NEWPORT_CONSOLE
7087

7188
endif
7289

73-
7490
endmenu

drivers/video/fbdev/core/Kconfig

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,6 @@ config FB_CORE
1010
config FB_NOTIFY
1111
bool
1212

13-
config FIRMWARE_EDID
14-
bool "Enable firmware EDID"
15-
depends on FB
16-
help
17-
This enables access to the EDID transferred from the firmware.
18-
On the i386, this is from the Video BIOS. Enable this if DDC/I2C
19-
transfers do not work for your driver and if you are using
20-
nvidiafb, i810fb or savagefb.
21-
22-
In general, choosing Y for this option is safe. If you
23-
experience extremely long delays while booting before you get
24-
something on your display, try setting this to N. Matrox cards in
25-
combination with certain motherboards and monitors are known to
26-
suffer from this problem.
27-
2813
config FB_DEVICE
2914
bool "Provide legacy /dev/fb* device"
3015
depends on FB_CORE

drivers/video/fbdev/core/fbmon.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1484,13 +1484,12 @@ int fb_validate_mode(const struct fb_var_screeninfo *var, struct fb_info *info)
14841484
-EINVAL : 0;
14851485
}
14861486

1487-
#if defined(CONFIG_FIRMWARE_EDID) && defined(CONFIG_X86)
1488-
14891487
/*
14901488
* We need to ensure that the EDID block is only returned for
14911489
* the primary graphics adapter.
14921490
*/
14931491

1492+
#if defined(CONFIG_FIRMWARE_EDID)
14941493
const unsigned char *fb_firmware_edid(struct device *device)
14951494
{
14961495
struct pci_dev *dev = NULL;

0 commit comments

Comments
 (0)