Skip to content

Commit 7e69a24

Browse files
ojedagregkh
authored andcommitted
rust_binder: clean clippy::mem_replace_with_default warning
Clippy reports: error: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` --> drivers/android/binder/node.rs:690:32 | 690 | _unused_capacity = mem::replace(&mut inner.freeze_list, KVVec::new()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut inner.freeze_list)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default = note: `-D clippy::mem-replace-with-default` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::mem_replace_with_default)]` The suggestion seems fine, thus apply it. Signed-off-by: Miguel Ojeda <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 3a86608 commit 7e69a24

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/android/binder/node.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,7 @@ impl Node {
687687
);
688688
}
689689
if inner.freeze_list.is_empty() {
690-
_unused_capacity = mem::replace(&mut inner.freeze_list, KVVec::new());
690+
_unused_capacity = mem::take(&mut inner.freeze_list);
691691
}
692692
}
693693

0 commit comments

Comments
 (0)