Skip to content

Commit 7f5f703

Browse files
lweiss-fairphonevinodkoul
authored andcommitted
phy: qcom: phy-qcom-snps-eusb2: Add missing write from init sequence
As per a commit from Qualcomm's downstream 6.1 kernel[0], the init sequence is missing setting the CMN_CTRL_OVERRIDE_EN bit back to 0 at the end, as per the 'latest' HPG revision (as of November 2023). [0] https://git.codelinaro.org/clo/la/kernel/qcom/-/commit/b77774a89e3fda3246e09dd39e16e2ab43cd1329 Fixes: 8009081 ("phy: qcom: Add QCOM SNPS eUSB2 driver") Reviewed-by: Konrad Dybcio <[email protected]> Reviewed-by: Neil Armstrong <[email protected]> Signed-off-by: Luca Weiss <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent bb39f49 commit 7f5f703

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/phy/phy-snps-eusb2.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -437,6 +437,9 @@ static int qcom_snps_eusb2_hsphy_init(struct phy *p)
437437
snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL2,
438438
USB2_SUSPEND_N_SEL, 0);
439439

440+
snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG0,
441+
CMN_CTRL_OVERRIDE_EN, 0);
442+
440443
return 0;
441444
}
442445

0 commit comments

Comments
 (0)