Skip to content

Commit 8b88b5e

Browse files
andredlag-linaro
authored andcommitted
mfd: sec: Move private internal API to internal header
sec_irq_init() is an internal API for the core driver, and doesn't belong into the public header. Due to an upcoming split of the driver into a core and i2c driver, we'll also be adding more internal APIs, which again shouldn't be in the public header. Move it into a new internal include. Reviewed-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: André Draszik <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lee Jones <[email protected]>
1 parent 5bef1b7 commit 8b88b5e

File tree

5 files changed

+18
-3
lines changed

5 files changed

+18
-3
lines changed

MAINTAINERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21457,7 +21457,7 @@ F: Documentation/devicetree/bindings/mfd/samsung,s5m*.yaml
2145721457
F: Documentation/devicetree/bindings/regulator/samsung,s2m*.yaml
2145821458
F: Documentation/devicetree/bindings/regulator/samsung,s5m*.yaml
2145921459
F: drivers/clk/clk-s2mps11.c
21460-
F: drivers/mfd/sec*.c
21460+
F: drivers/mfd/sec*.[ch]
2146121461
F: drivers/regulator/s2m*.c
2146221462
F: drivers/regulator/s5m*.c
2146321463
F: drivers/rtc/rtc-s5m.c

drivers/mfd/sec-core.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include <linux/pm.h>
2424
#include <linux/pm_runtime.h>
2525
#include <linux/regmap.h>
26+
#include "sec-core.h"
2627

2728
static const struct mfd_cell s5m8767_devs[] = {
2829
{ .name = "s5m8767-pmic", },

drivers/mfd/sec-core.h

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
/* SPDX-License-Identifier: GPL-2.0+ */
2+
/*
3+
* Copyright 2012 Samsung Electronics Co., Ltd
4+
* http://www.samsung.com
5+
* Copyright 2025 Linaro Ltd.
6+
*
7+
* Samsung SxM core driver internal data
8+
*/
9+
10+
#ifndef __SEC_CORE_INT_H
11+
#define __SEC_CORE_INT_H
12+
13+
int sec_irq_init(struct sec_pmic_dev *sec_pmic);
14+
15+
#endif /* __SEC_CORE_INT_H */

drivers/mfd/sec-irq.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
#include <linux/mfd/samsung/s5m8767.h>
1919
#include <linux/module.h>
2020
#include <linux/regmap.h>
21+
#include "sec-core.h"
2122

2223
static const struct regmap_irq s2mps11_irqs[] = {
2324
[S2MPS11_IRQ_PWRONF] = {

include/linux/mfd/samsung/core.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ struct sec_pmic_dev {
7171
struct regmap_irq_chip_data *irq_data;
7272
};
7373

74-
int sec_irq_init(struct sec_pmic_dev *sec_pmic);
75-
7674
struct sec_platform_data {
7775
struct sec_regulator_data *regulators;
7876
struct sec_opmode_data *opmode;

0 commit comments

Comments
 (0)