Skip to content

Commit 9359816

Browse files
committed
wifi: iwlwifi: mvm: assume '1' as the default mac_config_cmd version
Unfortunately, FWs of some devices don't have the version of the iwl_mac_config_cmd defined in the TLVs. We send 0 as the 'def argument to iwl_fw_lookup_cmd_ver, so for such FWs, the return value will be 0, leading to a warning, and to not sending the command. Fix this by assuming that the default version is 1. Fixes: 83f3ac2 ("wifi: iwlwifi: Fix incorrect logic on cmd_ver range checking") Signed-off-by: Miri Korenblit <[email protected]> Link: https://patch.msgid.link/[email protected]
1 parent 5c8013a commit 9359816

File tree

1 file changed

+2
-2
lines changed
  • drivers/net/wireless/intel/iwlwifi/mvm

1 file changed

+2
-2
lines changed

drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ static void iwl_mvm_mld_mac_ctxt_cmd_common(struct iwl_mvm *mvm,
3232
unsigned int link_id;
3333
int cmd_ver = iwl_fw_lookup_cmd_ver(mvm->fw,
3434
WIDE_ID(MAC_CONF_GROUP,
35-
MAC_CONFIG_CMD), 0);
35+
MAC_CONFIG_CMD), 1);
3636

37-
if (WARN_ON(cmd_ver < 1 || cmd_ver > 3))
37+
if (WARN_ON(cmd_ver > 3))
3838
return;
3939

4040
cmd->id_and_color = cpu_to_le32(mvmvif->id);

0 commit comments

Comments
 (0)