Skip to content

Commit 95b2e31

Browse files
visitorckwakpm00
authored andcommitted
bcache: remove unnecessary select MIN_HEAP
After reverting the transition to the generic min heap library, bcache no longer depends on MIN_HEAP. The select entry can be removed to reduce code size and shrink the kernel's attack surface. This change effectively reverts the bcache-related part of commit 92a8b22 ("lib/min_heap: introduce non-inline versions of min heap API functions"). This is part of a series of changes to address a performance regression caused by the use of the generic min_heap implementation. As reported by Robert, bcache now suffers from latency spikes, with P100 (max) latency increasing from 600 ms to 2.4 seconds every 5 minutes. These regressions degrade bcache's effectiveness as a low-latency cache layer and lead to frequent timeouts and application stalls in production environments. Link: https://lore.kernel.org/lkml/CAJhEC05+0S69z+3+FB2Cd0hD+pCRyWTKLEOsc8BOmH73p1m+KQ@mail.gmail.com Link: https://lkml.kernel.org/r/[email protected] Fixes: 866898e ("bcache: remove heap-related macros and switch to generic min_heap") Fixes: 92a8b22 ("lib/min_heap: introduce non-inline versions of min heap API functions") Signed-off-by: Kuan-Wei Chiu <[email protected]> Reported-by: Robert Pang <[email protected]> Closes: https://lore.kernel.org/linux-bcache/CAJhEC06F_AtrPgw2-7CvCqZgeStgCtitbD-ryuPpXQA-JG5XXw@mail.gmail.com Acked-by: Coly Li <[email protected]> Cc: Ching-Chun (Jim) Huang <[email protected]> Cc: Kent Overstreet <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 48fd7eb commit 95b2e31

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/md/bcache/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ config BCACHE
55
select BLOCK_HOLDER_DEPRECATED if SYSFS
66
select CRC64
77
select CLOSURES
8-
select MIN_HEAP
98
help
109
Allows a block device to be used as cache for other devices; uses
1110
a btree for indexing and the layout is optimized for SSDs.

0 commit comments

Comments
 (0)