io_uring/rw: use io_rw_recycle() from cleanup path

axboe · axboe · commit 9ac273ae3dc2 · 2025-01-10T07:51:38.000-07:00
Cleanup should always have the uring lock held, it's safe to recycle
from here.

Signed-off-by: Jens Axboe &lt;axboe@kernel.dk&gt;
diff --git a/io_uring/rw.c b/io_uring/rw.c
@@ -434,7 +434,8 @@ int io_read_mshot_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
 
 void io_readv_writev_cleanup(struct io_kiocb *req)
 {
-	io_rw_iovec_free(req->async_data);
+	lockdep_assert_held(&req->ctx->uring_lock);
+	io_rw_recycle(req, 0);
 }
 
 static inline loff_t *io_kiocb_update_pos(struct io_kiocb *req)

Original file line number	Diff line number	Diff line change
`@@ -434,7 +434,8 @@ int io_read_mshot_prep(struct io_kiocb req, const struct io_uring_sqe sqe)`
`434`	`434`
`435`	`435`	`void io_readv_writev_cleanup(struct io_kiocb *req)`
`436`	`436`	`{`
`437`		`- io_rw_iovec_free(req->async_data);`
	`437`	`+ lockdep_assert_held(&req->ctx->uring_lock);`
	`438`	`+ io_rw_recycle(req, 0);`
`438`	`439`	`}`
`439`	`440`
`440`	`441`	`static inline loff_t io_kiocb_update_pos(struct io_kiocb req)`