Skip to content

Commit 9c26a1d

Browse files
ole2plkuba-moo
authored andcommitted
net/mlx4: Add support for EEPROM high pages query for QSFP/QSFP+/QSFP28
Enable reading additional EEPROM information from high pages such as thresholds and alarms on QSFP/QSFP+/QSFP28 modules. "This is similar to commit a708fb7 ("net/mlx5e: ethtool, Add support for EEPROM high pages query") but given all the required logic already exists in mlx4_qsfp_eeprom_params_set() only s/_LEN/MAX_LEN/ is needed. Tested-by: Dan Merillat <[email protected]> Signed-off-by: Krzysztof Piotr Oledzki <[email protected]> Reviewed-by: Ido Schimmel <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 990c304 commit 9c26a1d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/net/ethernet/mellanox/mlx4/en_ethtool.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2036,20 +2036,20 @@ static int mlx4_en_get_module_info(struct net_device *dev,
20362036
switch (data[0] /* identifier */) {
20372037
case MLX4_MODULE_ID_QSFP:
20382038
modinfo->type = ETH_MODULE_SFF_8436;
2039-
modinfo->eeprom_len = ETH_MODULE_SFF_8436_LEN;
2039+
modinfo->eeprom_len = ETH_MODULE_SFF_8436_MAX_LEN;
20402040
break;
20412041
case MLX4_MODULE_ID_QSFP_PLUS:
20422042
if (data[1] >= 0x3) { /* revision id */
20432043
modinfo->type = ETH_MODULE_SFF_8636;
2044-
modinfo->eeprom_len = ETH_MODULE_SFF_8636_LEN;
2044+
modinfo->eeprom_len = ETH_MODULE_SFF_8636_MAX_LEN;
20452045
} else {
20462046
modinfo->type = ETH_MODULE_SFF_8436;
2047-
modinfo->eeprom_len = ETH_MODULE_SFF_8436_LEN;
2047+
modinfo->eeprom_len = ETH_MODULE_SFF_8436_MAX_LEN;
20482048
}
20492049
break;
20502050
case MLX4_MODULE_ID_QSFP28:
20512051
modinfo->type = ETH_MODULE_SFF_8636;
2052-
modinfo->eeprom_len = ETH_MODULE_SFF_8636_LEN;
2052+
modinfo->eeprom_len = ETH_MODULE_SFF_8636_MAX_LEN;
20532053
break;
20542054
case MLX4_MODULE_ID_SFP:
20552055
modinfo->type = ETH_MODULE_SFF_8472;

0 commit comments

Comments
 (0)