Skip to content

Commit 9e6448f

Browse files
pchaignoAlexei Starovoitov
authored andcommitted
bpf: Check netfilter ctx accesses are aligned
Similarly to the previous patch fixing the flow_dissector ctx accesses, nf_is_valid_access also doesn't check that ctx accesses are aligned. Contrary to flow_dissector programs, netfilter programs don't have context conversion. The unaligned ctx accesses are therefore allowed by the verifier. Fixes: fd9c663 ("bpf: minimal support for programs hooked into netfilter framework") Signed-off-by: Paul Chaignon <[email protected]> Acked-by: Yonghong Song <[email protected]> Acked-by: Eduard Zingerman <[email protected]> Link: https://lore.kernel.org/r/853ae9ed5edaa5196e8472ff0f1bb1cc24059214.1754039605.git.paul.chaignon@gmail.com Signed-off-by: Alexei Starovoitov <[email protected]>
1 parent ead3d7b commit 9e6448f

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

net/netfilter/nf_bpf_link.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,9 @@ static bool nf_is_valid_access(int off, int size, enum bpf_access_type type,
296296
if (off < 0 || off >= sizeof(struct bpf_nf_ctx))
297297
return false;
298298

299+
if (off % size != 0)
300+
return false;
301+
299302
if (type == BPF_WRITE)
300303
return false;
301304

0 commit comments

Comments
 (0)