Skip to content

Commit 9f4701e

Browse files
tlendackysean-jc
authored andcommitted
KVM: SVM: Allow SNP guest policy disallow running with SMT enabled
KVM currently returns -EINVAL when it attempts to create an SNP guest if the SMT guest policy bit is not set. However, there is no reason to check this, as there is no specific support in KVM that is required to support this. The SEV firmware will determine if SMT has been enabled or disabled in the BIOS and process the policy in the proper way: - SMT enabled in BIOS - Guest policy SMT == 0 ==> SNP_LAUNCH_START fails with POLICY_FAILURE - Guest policy SMT == 1 ==> SNP_LAUNCH_START succeeds - SMT disabled in BIOS - Guest policy SMT == 0 ==> SNP_LAUNCH_START succeeds - Guest policy SMT == 1 ==> SNP_LAUNCH_START succeeds Remove the check for the SMT policy bit from snp_launch_start() and allow the firmware to perform the proper checking. Signed-off-by: Tom Lendacky <[email protected]> Link: https://lore.kernel.org/r/71043abdd9ef23b6f98fffa9c5c6045ac3a50187.1748553480.git.thomas.lendacky@amd.com Signed-off-by: Sean Christopherson <[email protected]>
1 parent 28224ef commit 9f4701e

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

arch/x86/kvm/svm/sev.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2131,8 +2131,7 @@ static int snp_launch_start(struct kvm *kvm, struct kvm_sev_cmd *argp)
21312131
return -EINVAL;
21322132

21332133
/* Check for policy bits that must be set */
2134-
if (!(params.policy & SNP_POLICY_MASK_RSVD_MBO) ||
2135-
!(params.policy & SNP_POLICY_MASK_SMT))
2134+
if (!(params.policy & SNP_POLICY_MASK_RSVD_MBO))
21362135
return -EINVAL;
21372136

21382137
if (params.policy & SNP_POLICY_MASK_SINGLE_SOCKET)

0 commit comments

Comments
 (0)