Skip to content

Commit a48a931

Browse files
Baochen Qiangjeff-t-johnson
authored andcommitted
wifi: ath12k: fix documentation on firmware stats
Regarding the firmware stats events handling, the comment in ath12k_mac_get_fw_stats() says host determines whether all events have been received based on 'end' tag in TLV. This is wrong as there is no such tag at all, actually host makes the decision totally by itself based on the stats type and active pdev/vdev counts etc. Fix it to correctly reflect the logic. Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00284.1-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Tested-on: QCN9274 hw2.0 WLAN.WBE.1.5-01651-QCAHKSWPL_SILICONZ-1 Signed-off-by: Baochen Qiang <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jeff Johnson <[email protected]>
1 parent d9dbc6b commit a48a931

File tree

1 file changed

+2
-3
lines changed
  • drivers/net/wireless/ath/ath12k

1 file changed

+2
-3
lines changed

drivers/net/wireless/ath/ath12k/mac.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4400,9 +4400,8 @@ int ath12k_mac_get_fw_stats(struct ath12k *ar,
44004400
/* Firmware sends WMI_UPDATE_STATS_EVENTID back-to-back
44014401
* when stats data buffer limit is reached. fw_stats_complete
44024402
* is completed once host receives first event from firmware, but
4403-
* still end might not be marked in the TLV.
4404-
* Below loop is to confirm that firmware completed sending all the event
4405-
* and fw_stats_done is marked true when end is marked in the TLV.
4403+
* still there could be more events following. Below loop is to wait
4404+
* until firmware completes sending all the events.
44064405
*/
44074406
for (;;) {
44084407
if (time_after(jiffies, timeout))

0 commit comments

Comments
 (0)