Skip to content

Commit a6984a3

Browse files
committed
drm/msm/hdmi: drop clock frequency assignment
The only clock which has frequency being set through hpd_freqs is the "core" aka MDSS_HDMI_CLK clock. It always has the specified frequency, so we can drop corresponding clk_set_rate() call together with the hpd_freq infrastructure. Reviewed-by: Jessica Zhang <[email protected]> Signed-off-by: Dmitry Baryshkov <[email protected]> Patchwork: https://patchwork.freedesktop.org/patch/651717/ Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dmitry Baryshkov <[email protected]>
1 parent 7e53b0a commit a6984a3

File tree

3 files changed

+0
-12
lines changed

3 files changed

+0
-12
lines changed

drivers/gpu/drm/msm/hdmi/hdmi.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,12 +234,10 @@ static const struct hdmi_platform_config hdmi_tx_8960_config = {
234234

235235
static const char * const pwr_reg_names_8x74[] = {"core-vdda", "core-vcc"};
236236
static const char * const hpd_clk_names_8x74[] = {"iface", "core", "mdp_core", "alt_iface"};
237-
static unsigned long hpd_clk_freq_8x74[] = {0, 19200000, 0, 0};
238237

239238
static const struct hdmi_platform_config hdmi_tx_8974_config = {
240239
HDMI_CFG(pwr_reg, 8x74),
241240
HDMI_CFG(hpd_clk, 8x74),
242-
.hpd_freq = hpd_clk_freq_8x74,
243241
};
244242

245243
static int msm_hdmi_bind(struct device *dev, struct device *master, void *data)

drivers/gpu/drm/msm/hdmi/hdmi.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ struct hdmi_platform_config {
9393

9494
/* clks that need to be on for hpd: */
9595
const char * const *hpd_clk_names;
96-
const long unsigned *hpd_freq;
9796
int hpd_clk_cnt;
9897
};
9998

drivers/gpu/drm/msm/hdmi/hdmi_hpd.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,6 @@ static void enable_hpd_clocks(struct hdmi *hdmi, bool enable)
6868

6969
if (enable) {
7070
for (i = 0; i < config->hpd_clk_cnt; i++) {
71-
if (config->hpd_freq && config->hpd_freq[i]) {
72-
ret = clk_set_rate(hdmi->hpd_clks[i],
73-
config->hpd_freq[i]);
74-
if (ret)
75-
dev_warn(dev,
76-
"failed to set clk %s (%d)\n",
77-
config->hpd_clk_names[i], ret);
78-
}
79-
8071
ret = clk_prepare_enable(hdmi->hpd_clks[i]);
8172
if (ret) {
8273
DRM_DEV_ERROR(dev,

0 commit comments

Comments
 (0)