Skip to content

Commit b664564

Browse files
1997cuikuba-moo
authored andcommitted
selftests/drivers/net: Support ipv6 for napi_id test
Add support for IPv6 environment for napi_id test. Test Plan: ./run_kselftest.sh -t drivers/net:napi_id.py TAP version 13 1..1 # timeout set to 45 # selftests: drivers/net: napi_id.py # TAP version 13 # 1..1 # ok 1 napi_id.test_napi_id # # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 ok 1 selftests: drivers/net: napi_id.py Signed-off-by: Tianyi Cui <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent efe2803 commit b664564

File tree

2 files changed

+28
-11
lines changed

2 files changed

+28
-11
lines changed

tools/testing/selftests/drivers/net/napi_id.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77

88
def test_napi_id(cfg) -> None:
99
port = rand_port()
10-
listen_cmd = f"{cfg.test_dir}/napi_id_helper {cfg.addr_v['4']} {port}"
10+
listen_cmd = f"{cfg.test_dir}/napi_id_helper {cfg.addr} {port}"
1111

1212
with bkg(listen_cmd, ksft_wait=3) as server:
13-
cmd(f"echo a | socat - TCP:{cfg.addr_v['4']}:{port}", host=cfg.remote, shell=True)
13+
cmd(f"echo a | socat - TCP:{cfg.baddr}:{port}", host=cfg.remote, shell=True)
1414

1515
ksft_eq(0, server.ret)
1616

tools/testing/selftests/drivers/net/napi_id_helper.c

Lines changed: 26 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,41 +7,58 @@
77
#include <unistd.h>
88
#include <arpa/inet.h>
99
#include <sys/socket.h>
10+
#include <netdb.h>
1011

1112
#include "../../net/lib/ksft.h"
1213

1314
int main(int argc, char *argv[])
1415
{
15-
struct sockaddr_in address;
16+
struct sockaddr_storage address;
17+
struct addrinfo *result;
18+
struct addrinfo hints;
1619
unsigned int napi_id;
17-
unsigned int port;
20+
socklen_t addr_len;
1821
socklen_t optlen;
1922
char buf[1024];
2023
int opt = 1;
24+
int family;
2125
int server;
2226
int client;
2327
int ret;
2428

25-
server = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
29+
memset(&hints, 0, sizeof(hints));
30+
hints.ai_family = AF_UNSPEC;
31+
hints.ai_socktype = SOCK_STREAM;
32+
hints.ai_flags = AI_PASSIVE;
33+
34+
ret = getaddrinfo(argv[1], argv[2], &hints, &result);
35+
if (ret != 0) {
36+
fprintf(stderr, "getaddrinfo: %s\n", gai_strerror(ret));
37+
return 1;
38+
}
39+
40+
family = result->ai_family;
41+
addr_len = result->ai_addrlen;
42+
43+
server = socket(family, SOCK_STREAM, IPPROTO_TCP);
2644
if (server < 0) {
2745
perror("socket creation failed");
46+
freeaddrinfo(result);
2847
if (errno == EAFNOSUPPORT)
2948
return -1;
3049
return 1;
3150
}
3251

33-
port = atoi(argv[2]);
34-
3552
if (setsockopt(server, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(opt))) {
3653
perror("setsockopt");
54+
freeaddrinfo(result);
3755
return 1;
3856
}
3957

40-
address.sin_family = AF_INET;
41-
inet_pton(AF_INET, argv[1], &address.sin_addr);
42-
address.sin_port = htons(port);
58+
memcpy(&address, result->ai_addr, result->ai_addrlen);
59+
freeaddrinfo(result);
4360

44-
if (bind(server, (struct sockaddr *)&address, sizeof(address)) < 0) {
61+
if (bind(server, (struct sockaddr *)&address, addr_len) < 0) {
4562
perror("bind failed");
4663
return 1;
4764
}

0 commit comments

Comments
 (0)