Skip to content

Commit b7996f8

Browse files
jhovoldvinodkoul
authored andcommitted
phy: phy-snps-eusb2: clean up error messages
Clean up the error messages by using a consistent format with a colon followed by a space and an errno (or unsupported frequency). Signed-off-by: Johan Hovold <[email protected]> Reviewed-by: Neil Armstrong <[email protected]> Reviewed-by: Abel Vesa <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 4f33399 commit b7996f8

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/phy/phy-snps-eusb2.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ static int exynos_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy)
256256
}
257257

258258
if (!config) {
259-
dev_err(&phy->phy->dev, "unsupported ref_clk_freq:%lu\n", ref_clk_freq);
259+
dev_err(&phy->phy->dev, "unsupported ref_clk_freq: %lu\n", ref_clk_freq);
260260
return -EINVAL;
261261
}
262262

@@ -293,7 +293,7 @@ static int qcom_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy)
293293
}
294294

295295
if (!config) {
296-
dev_err(&phy->phy->dev, "unsupported ref_clk_freq:%lu\n", ref_clk_freq);
296+
dev_err(&phy->phy->dev, "unsupported ref_clk_freq: %lu\n", ref_clk_freq);
297297
return -EINVAL;
298298
}
299299

@@ -461,27 +461,27 @@ static int snps_eusb2_hsphy_init(struct phy *p)
461461

462462
ret = phy_init(phy->repeater);
463463
if (ret) {
464-
dev_err(&p->dev, "repeater init failed. %d\n", ret);
464+
dev_err(&p->dev, "repeater init failed: %d\n", ret);
465465
goto disable_vreg;
466466
}
467467

468468
ret = clk_bulk_prepare_enable(phy->data->num_clks, phy->clks);
469469
if (ret) {
470-
dev_err(&p->dev, "failed to enable ref clock, %d\n", ret);
470+
dev_err(&p->dev, "failed to enable ref clock: %d\n", ret);
471471
goto exit_repeater;
472472
}
473473

474474
ret = reset_control_assert(phy->phy_reset);
475475
if (ret) {
476-
dev_err(&p->dev, "failed to assert phy_reset, %d\n", ret);
476+
dev_err(&p->dev, "failed to assert phy_reset: %d\n", ret);
477477
goto disable_clks;
478478
}
479479

480480
usleep_range(100, 150);
481481

482482
ret = reset_control_deassert(phy->phy_reset);
483483
if (ret) {
484-
dev_err(&p->dev, "failed to de-assert phy_reset, %d\n", ret);
484+
dev_err(&p->dev, "failed to de-assert phy_reset: %d\n", ret);
485485
goto disable_clks;
486486
}
487487

@@ -588,7 +588,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev)
588588

589589
generic_phy = devm_phy_create(dev, NULL, &snps_eusb2_hsphy_ops);
590590
if (IS_ERR(generic_phy)) {
591-
dev_err(dev, "failed to create phy %d\n", ret);
591+
dev_err(dev, "failed to create phy: %d\n", ret);
592592
return PTR_ERR(generic_phy);
593593
}
594594

0 commit comments

Comments
 (0)