HID: pidff: Rework pidff_set_time() to fix warnings

Lawstorant · Jiri Kosina · commit bed72bd240ce · 2025-06-10T21:28:22.000+02:00
Fixes blank line warning from checkpatch.pl script

Signed-off-by: Tomasz Pakuła &lt;tomasz.pakula.oficjalny@gmail.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.com&gt;
diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
@@ -273,8 +273,8 @@ static void pidff_set_signed(struct pidff_usage *usage, s16 value)
 
 static void pidff_set_time(struct pidff_usage *usage, u16 time)
 {
-	u32 modified_time = pidff_rescale_time(time, usage->field);
-	usage->value[0] = pidff_clamp(modified_time, usage->field);
+	usage->value[0] = pidff_clamp(
+		pidff_rescale_time(time, usage->field), usage->field);
 }
 
 static void pidff_set_duration(struct pidff_usage *usage, u16 duration)

Original file line number	Diff line number	Diff line change
`@@ -273,8 +273,8 @@ static void pidff_set_signed(struct pidff_usage *usage, s16 value)`
`273`	`273`
`274`	`274`	`static void pidff_set_time(struct pidff_usage *usage, u16 time)`
`275`	`275`	`{`
`276`		`- u32 modified_time = pidff_rescale_time(time, usage->field);`
`277`		`- usage->value[0] = pidff_clamp(modified_time, usage->field);`
	`276`	`+ usage->value[0] = pidff_clamp(`
	`277`	`+ pidff_rescale_time(time, usage->field), usage->field);`
`278`	`278`	`}`
`279`	`279`
`280`	`280`	`static void pidff_set_duration(struct pidff_usage *usage, u16 duration)`