Skip to content

Commit c36420d

Browse files
author
Bartosz Golaszewski
committed
gpio: TODO: remove the pinctrl integration task
While there are surely some arguments in favor of integrating the GPIO and pinctrl subsystems into one, I believe this is not the right approach. The GPIO subsystem uses intricate locking with SRCU to handle the fact that both consumers and providers may run in different contexts. Pin-controller drivers are always meant to run in process context. This alone is a huge obstacle to any attempt at integration as evident by many problems we already encountered during the hotplug rework. The current glue code is pretty minimal and for most part already allows GPIO controllers to query pinctrl about the information they need. I suggest to drop this task and keep the subsystems separate even if many pin-controllers implement GPIO functionality in addition to pin functions. Reviewed-by: Linus Walleij <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bartosz Golaszewski <[email protected]>
1 parent 01cbfc4 commit c36420d

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

drivers/gpio/TODO

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -136,17 +136,6 @@ try to cover any generic kind of irqchip cascaded from a GPIO.
136136
dry-code conversions to gpiolib irqchip for maintainers to test
137137

138138

139-
Increase integration with pin control
140-
141-
There are already ways to use pin control as back-end for GPIO and
142-
it may make sense to bring these subsystems closer. One reason for
143-
creating pin control as its own subsystem was that we could avoid any
144-
use of the global GPIO numbers. Once the above is complete, it may
145-
make sense to simply join the subsystems into one and make pin
146-
multiplexing, pin configuration, GPIO, etc selectable options in one
147-
and the same pin control and GPIO subsystem.
148-
149-
150139
Moving over to immutable irq_chip structures
151140

152141
Most of the gpio chips implementing interrupt support rely on gpiolib

0 commit comments

Comments
 (0)