Skip to content

Commit c7b4950

Browse files
vsyrjalarodrigovivi
authored andcommitted
drm/i915: Drop 64bpp YUV formats from ICL+ SDR planes
I'm seeing underruns with these 64bpp YUV formats on TGL. The weird details: - only happens on pipe B/C/D SDR planes, pipe A SDR planes seem fine, as do all HDR planes - somehow CDCLK related, higher CDCLK allows for bigger plane with these formats without underruns. With 300MHz CDCLK I can only go up to 1200 pixels wide or so, with 650MHz even a 3840 pixel wide plane was OK - ICL and ADL so far appear unaffected So not really sure what's the deal with this, but bspec does state "64-bit formats supported only on the HDR planes" so let's just drop these formats from the SDR planes. We already disallow 64bpp RGB formats. Cc: [email protected] Signed-off-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Juha-Pekka Heikkila <[email protected]> (cherry picked from commit 35e1aac) Signed-off-by: Rodrigo Vivi <[email protected]>
1 parent fa6182c commit c7b4950

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/gpu/drm/i915/display/skl_universal_plane.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,6 @@ static const u32 icl_sdr_y_plane_formats[] = {
106106
DRM_FORMAT_Y216,
107107
DRM_FORMAT_XYUV8888,
108108
DRM_FORMAT_XVYU2101010,
109-
DRM_FORMAT_XVYU12_16161616,
110-
DRM_FORMAT_XVYU16161616,
111109
};
112110

113111
static const u32 icl_sdr_uv_plane_formats[] = {
@@ -134,8 +132,6 @@ static const u32 icl_sdr_uv_plane_formats[] = {
134132
DRM_FORMAT_Y216,
135133
DRM_FORMAT_XYUV8888,
136134
DRM_FORMAT_XVYU2101010,
137-
DRM_FORMAT_XVYU12_16161616,
138-
DRM_FORMAT_XVYU16161616,
139135
};
140136

141137
static const u32 icl_hdr_plane_formats[] = {

0 commit comments

Comments
 (0)