Skip to content

Commit d281851

Browse files
committed
Merge tag 'block-6.18-20251023' of git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux
Pull block fixes from Jens Axboe: - Fix dma alignment for PI - Fix selinux bogosity with nbd, where sendmsg would get rejected * tag 'block-6.18-20251023' of git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux: block: require LBA dma_alignment when using PI nbd: override creds to kernel when calling sock_{send,recv}msg()
2 parents 812e7eb + 4c8cf6b commit d281851

File tree

2 files changed

+25
-0
lines changed

2 files changed

+25
-0
lines changed

block/blk-settings.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,16 @@ static int blk_validate_integrity_limits(struct queue_limits *lim)
184184
if (!bi->interval_exp)
185185
bi->interval_exp = ilog2(lim->logical_block_size);
186186

187+
/*
188+
* The PI generation / validation helpers do not expect intervals to
189+
* straddle multiple bio_vecs. Enforce alignment so that those are
190+
* never generated, and that each buffer is aligned as expected.
191+
*/
192+
if (bi->csum_type) {
193+
lim->dma_alignment = max(lim->dma_alignment,
194+
(1U << bi->interval_exp) - 1);
195+
}
196+
187197
return 0;
188198
}
189199

drivers/block/nbd.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
static DEFINE_IDR(nbd_index_idr);
5353
static DEFINE_MUTEX(nbd_index_mutex);
5454
static struct workqueue_struct *nbd_del_wq;
55+
static struct cred *nbd_cred;
5556
static int nbd_total_devices = 0;
5657

5758
struct nbd_sock {
@@ -554,6 +555,7 @@ static int __sock_xmit(struct nbd_device *nbd, struct socket *sock, int send,
554555
int result;
555556
struct msghdr msg = {} ;
556557
unsigned int noreclaim_flag;
558+
const struct cred *old_cred;
557559

558560
if (unlikely(!sock)) {
559561
dev_err_ratelimited(disk_to_dev(nbd->disk),
@@ -562,6 +564,8 @@ static int __sock_xmit(struct nbd_device *nbd, struct socket *sock, int send,
562564
return -EINVAL;
563565
}
564566

567+
old_cred = override_creds(nbd_cred);
568+
565569
msg.msg_iter = *iter;
566570

567571
noreclaim_flag = memalloc_noreclaim_save();
@@ -586,6 +590,8 @@ static int __sock_xmit(struct nbd_device *nbd, struct socket *sock, int send,
586590

587591
memalloc_noreclaim_restore(noreclaim_flag);
588592

593+
revert_creds(old_cred);
594+
589595
return result;
590596
}
591597

@@ -2677,7 +2683,15 @@ static int __init nbd_init(void)
26772683
return -ENOMEM;
26782684
}
26792685

2686+
nbd_cred = prepare_kernel_cred(&init_task);
2687+
if (!nbd_cred) {
2688+
destroy_workqueue(nbd_del_wq);
2689+
unregister_blkdev(NBD_MAJOR, "nbd");
2690+
return -ENOMEM;
2691+
}
2692+
26802693
if (genl_register_family(&nbd_genl_family)) {
2694+
put_cred(nbd_cred);
26812695
destroy_workqueue(nbd_del_wq);
26822696
unregister_blkdev(NBD_MAJOR, "nbd");
26832697
return -EINVAL;
@@ -2732,6 +2746,7 @@ static void __exit nbd_cleanup(void)
27322746
/* Also wait for nbd_dev_remove_work() completes */
27332747
destroy_workqueue(nbd_del_wq);
27342748

2749+
put_cred(nbd_cred);
27352750
idr_destroy(&nbd_index_idr);
27362751
unregister_blkdev(NBD_MAJOR, "nbd");
27372752
}

0 commit comments

Comments
 (0)