xfs: remove the call to sync_blockdev in xfs_configure_buftarg

Christoph Hellwig · cmaiolino · commit d9b1e348cff7 · 2025-07-08T13:30:26.000+02:00
This extra call is not needed as xfs_alloc_buftarg already calls
sync_blockdev.

Signed-off-by: Christoph Hellwig &lt;hch@lst.de&gt;
Reviewed-by: John Garry &lt;john.g.garry@oracle.com&gt;
Signed-off-by: Carlos Maiolino &lt;cem@kernel.org&gt;
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
@@ -1738,14 +1738,9 @@ xfs_configure_buftarg(
 		return -EINVAL;
 	}
 
-	/*
-	 * Flush the block device pagecache so our bios see anything dirtied
-	 * before mount.
-	 */
 	if (bdev_can_atomic_write(btp->bt_bdev))
 		xfs_configure_buftarg_atomic_writes(btp);
-
-	return sync_blockdev(btp->bt_bdev);
+	return 0;
 }
 
 int

Original file line number	Diff line number	Diff line change
`@@ -1738,14 +1738,9 @@ xfs_configure_buftarg(`
`1738`	`1738`	`return -EINVAL;`
`1739`	`1739`	`}`
`1740`	`1740`
`1741`		`- /*`
`1742`		`- * Flush the block device pagecache so our bios see anything dirtied`
`1743`		`- * before mount.`
`1744`		`- */`
`1745`	`1741`	`if (bdev_can_atomic_write(btp->bt_bdev))`
`1746`	`1742`	`xfs_configure_buftarg_atomic_writes(btp);`
`1747`		`-`
`1748`		`- return sync_blockdev(btp->bt_bdev);`
	`1743`	`+ return 0;`
`1749`	`1744`	`}`
`1750`	`1745`
`1751`	`1746`	`int`