Skip to content

Commit d9ea58b

Browse files
roxellmstsirkin
authored andcommitted
vdpa: Fix IDR memory leak in VDUSE module exit
Add missing idr_destroy() call in vduse_exit() to properly free the vduse_idr radix tree nodes. Without this, module load/unload cycles leak 576-byte radix tree node allocations, detectable by kmemleak as: unreferenced object (size 576): backtrace: [<ffffffff81234567>] radix_tree_node_alloc+0xa0/0xf0 [<ffffffff81234568>] idr_get_free+0x128/0x280 The vduse_idr is initialized via DEFINE_IDR() at line 136 and used throughout the VDUSE (vDPA Device in Userspace) driver for device ID management. The fix follows the documented pattern in lib/idr.c and matches the cleanup approach used by other drivers. This leak was discovered through comprehensive module testing with cumulative kmemleak detection across 10 load/unload iterations per module. Fixes: c8a6153 ("vduse: Introduce VDUSE - vDPA Device in Userspace") Signed-off-by: Anders Roxell <[email protected]> Message-Id: <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
1 parent cc51a66 commit d9ea58b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/vdpa/vdpa_user/vduse_dev.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2216,6 +2216,7 @@ static void vduse_exit(void)
22162216
cdev_del(&vduse_ctrl_cdev);
22172217
unregister_chrdev_region(vduse_major, VDUSE_DEV_MAX);
22182218
class_unregister(&vduse_class);
2219+
idr_destroy(&vduse_idr);
22192220
}
22202221
module_exit(vduse_exit);
22212222

0 commit comments

Comments
 (0)