Skip to content

Commit dcf5582

Browse files
KKaras169169Andi Shyti
authored andcommitted
drm/i915: Move out engine related macros from i915_drv.h
Move macros related to engines out of i915_drv.h header and place them in intel_engine.h. Signed-off-by: Krzysztof Karas <[email protected]> Reviewed-by: Andi Shyti <[email protected]> Signed-off-by: Andi Shyti <[email protected]> Link: https://lore.kernel.org/r/9b9ed5bbdb37470fa679c5baf961424c9cfbad11.1750251040.git.krzysztof.karas@intel.com
1 parent c371161 commit dcf5582

File tree

2 files changed

+31
-31
lines changed

2 files changed

+31
-31
lines changed

drivers/gpu/drm/i915/gt/intel_engine.h

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,29 @@ struct lock_class_key;
7979
#define ENGINE_WRITE(...) __ENGINE_WRITE_OP(write, __VA_ARGS__)
8080
#define ENGINE_WRITE_FW(...) __ENGINE_WRITE_OP(write_fw, __VA_ARGS__)
8181

82+
#define __HAS_ENGINE(engine_mask, id) ((engine_mask) & BIT(id))
83+
#define HAS_ENGINE(gt, id) __HAS_ENGINE((gt)->info.engine_mask, id)
84+
85+
#define __ENGINE_INSTANCES_MASK(mask, first, count) ({ \
86+
unsigned int first__ = (first); \
87+
unsigned int count__ = (count); \
88+
((mask) & GENMASK(first__ + count__ - 1, first__)) >> first__; \
89+
})
90+
91+
#define ENGINE_INSTANCES_MASK(gt, first, count) \
92+
__ENGINE_INSTANCES_MASK((gt)->info.engine_mask, first, count)
93+
94+
#define RCS_MASK(gt) \
95+
ENGINE_INSTANCES_MASK(gt, RCS0, I915_MAX_RCS)
96+
#define BCS_MASK(gt) \
97+
ENGINE_INSTANCES_MASK(gt, BCS0, I915_MAX_BCS)
98+
#define VDBOX_MASK(gt) \
99+
ENGINE_INSTANCES_MASK(gt, VCS0, I915_MAX_VCS)
100+
#define VEBOX_MASK(gt) \
101+
ENGINE_INSTANCES_MASK(gt, VECS0, I915_MAX_VECS)
102+
#define CCS_MASK(gt) \
103+
ENGINE_INSTANCES_MASK(gt, CCS0, I915_MAX_CCS)
104+
82105
#define GEN6_RING_FAULT_REG_READ(engine__) \
83106
intel_uncore_read((engine__)->uncore, RING_FAULT_REG(engine__))
84107

@@ -355,4 +378,12 @@ u64 intel_clamp_preempt_timeout_ms(struct intel_engine_cs *engine, u64 value);
355378
u64 intel_clamp_stop_timeout_ms(struct intel_engine_cs *engine, u64 value);
356379
u64 intel_clamp_timeslice_duration_ms(struct intel_engine_cs *engine, u64 value);
357380

381+
#define rb_to_uabi_engine(rb) \
382+
rb_entry_safe(rb, struct intel_engine_cs, uabi_node)
383+
384+
#define for_each_uabi_engine(engine__, i915__) \
385+
for ((engine__) = rb_to_uabi_engine(rb_first(&(i915__)->uabi_engines));\
386+
(engine__); \
387+
(engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
388+
358389
#endif /* _INTEL_RINGBUFFER_H_ */

drivers/gpu/drm/i915/i915_drv.h

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -374,14 +374,6 @@ static inline struct intel_gt *to_gt(const struct drm_i915_private *i915)
374374
return i915->gt[0];
375375
}
376376

377-
#define rb_to_uabi_engine(rb) \
378-
rb_entry_safe(rb, struct intel_engine_cs, uabi_node)
379-
380-
#define for_each_uabi_engine(engine__, i915__) \
381-
for ((engine__) = rb_to_uabi_engine(rb_first(&(i915__)->uabi_engines));\
382-
(engine__); \
383-
(engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
384-
385377
#define INTEL_INFO(i915) ((i915)->__info)
386378
#define RUNTIME_INFO(i915) (&(i915)->__runtime)
387379
#define DRIVER_CAPS(i915) (&(i915)->caps)
@@ -590,29 +582,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
590582
#define IS_GEN9_LP(i915) (IS_BROXTON(i915) || IS_GEMINILAKE(i915))
591583
#define IS_GEN9_BC(i915) (GRAPHICS_VER(i915) == 9 && !IS_GEN9_LP(i915))
592584

593-
#define __HAS_ENGINE(engine_mask, id) ((engine_mask) & BIT(id))
594-
#define HAS_ENGINE(gt, id) __HAS_ENGINE((gt)->info.engine_mask, id)
595-
596-
#define __ENGINE_INSTANCES_MASK(mask, first, count) ({ \
597-
unsigned int first__ = (first); \
598-
unsigned int count__ = (count); \
599-
((mask) & GENMASK(first__ + count__ - 1, first__)) >> first__; \
600-
})
601-
602-
#define ENGINE_INSTANCES_MASK(gt, first, count) \
603-
__ENGINE_INSTANCES_MASK((gt)->info.engine_mask, first, count)
604-
605-
#define RCS_MASK(gt) \
606-
ENGINE_INSTANCES_MASK(gt, RCS0, I915_MAX_RCS)
607-
#define BCS_MASK(gt) \
608-
ENGINE_INSTANCES_MASK(gt, BCS0, I915_MAX_BCS)
609-
#define VDBOX_MASK(gt) \
610-
ENGINE_INSTANCES_MASK(gt, VCS0, I915_MAX_VCS)
611-
#define VEBOX_MASK(gt) \
612-
ENGINE_INSTANCES_MASK(gt, VECS0, I915_MAX_VECS)
613-
#define CCS_MASK(gt) \
614-
ENGINE_INSTANCES_MASK(gt, CCS0, I915_MAX_CCS)
615-
616585
#define HAS_MEDIA_RATIO_MODE(i915) (INTEL_INFO(i915)->has_media_ratio_mode)
617586

618587
/*

0 commit comments

Comments
 (0)