Skip to content

Commit ddb9680

Browse files
author
Kent Overstreet
committed
bcachefs: Fix bch2_io_failures_to_text()
This wasn't updated when we added tracking for btree validate errors. Signed-off-by: Kent Overstreet <[email protected]>
1 parent 63d6e93 commit ddb9680

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

fs/bcachefs/extents.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,17 @@ void bch2_io_failures_to_text(struct printbuf *out,
5050
struct bch_io_failures *failed)
5151
{
5252
static const char * const error_types[] = {
53-
"io", "checksum", "ec reconstruct", NULL
53+
"btree validate", "io", "checksum", "ec reconstruct", NULL
5454
};
5555

5656
for (struct bch_dev_io_failures *f = failed->devs;
5757
f < failed->devs + failed->nr;
5858
f++) {
5959
unsigned errflags =
60-
((!!f->failed_io) << 0) |
61-
((!!f->failed_csum_nr) << 1) |
62-
((!!f->failed_ec) << 2);
63-
64-
if (!errflags)
65-
continue;
60+
((!!f->failed_btree_validate) << 0) |
61+
((!!f->failed_io) << 1) |
62+
((!!f->failed_csum_nr) << 2) |
63+
((!!f->failed_ec) << 3);
6664

6765
bch2_printbuf_make_room(out, 1024);
6866
out->atomic++;
@@ -77,7 +75,9 @@ void bch2_io_failures_to_text(struct printbuf *out,
7775

7876
prt_char(out, ' ');
7977

80-
if (is_power_of_2(errflags)) {
78+
if (!errflags) {
79+
prt_str(out, "no error - confused");
80+
} else if (is_power_of_2(errflags)) {
8181
prt_bitflags(out, error_types, errflags);
8282
prt_str(out, " error");
8383
} else {

0 commit comments

Comments
 (0)