Skip to content

Commit e3fd06d

Browse files
committed
wifi: iwlwifi: mvm: remove support for REDUCE_TX_POWER_CMD ver 6 and 7
These versions are no longer used in any of our devices. Remove them. Reviewed-by: Johannes Berg <[email protected]> Signed-off-by: Miri Korenblit <[email protected]> Link: https://patch.msgid.link/20250711183056.05fabbda0a2f.Id55eeb4f337eb52163621ca202d97a3539bf3f53@changeid
1 parent bf6ce41 commit e3fd06d

File tree

3 files changed

+4
-62
lines changed

3 files changed

+4
-62
lines changed

drivers/net/wireless/intel/iwlwifi/fw/api/power.h

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -341,50 +341,6 @@ struct iwl_dev_tx_power_cmd_v5 {
341341
__le32 timer_period;
342342
} __packed; /* TX_REDUCED_POWER_API_S_VER_5 */
343343

344-
/**
345-
* struct iwl_dev_tx_power_cmd_v6 - TX power reduction command version 6
346-
* @per_chain: per chain restrictions
347-
* @enable_ack_reduction: enable or disable close range ack TX power
348-
* reduction.
349-
* @per_chain_restriction_changed: is per_chain_restriction has changed
350-
* from last command. used if set_mode is
351-
* IWL_TX_POWER_MODE_SET_SAR_TIMER.
352-
* note: if not changed, the command is used for keep alive only.
353-
* @reserved: reserved (padding)
354-
* @timer_period: timer in milliseconds. if expires FW will change to default
355-
* BIOS values. relevant if setMode is IWL_TX_POWER_MODE_SET_SAR_TIMER
356-
*/
357-
struct iwl_dev_tx_power_cmd_v6 {
358-
__le16 per_chain[IWL_NUM_CHAIN_TABLES_V2][IWL_NUM_CHAIN_LIMITS][IWL_NUM_SUB_BANDS_V2];
359-
u8 enable_ack_reduction;
360-
u8 per_chain_restriction_changed;
361-
u8 reserved[2];
362-
__le32 timer_period;
363-
} __packed; /* TX_REDUCED_POWER_API_S_VER_6 */
364-
365-
/**
366-
* struct iwl_dev_tx_power_cmd_v7 - TX power reduction command version 7
367-
* @per_chain: per chain restrictions
368-
* @enable_ack_reduction: enable or disable close range ack TX power
369-
* reduction.
370-
* @per_chain_restriction_changed: is per_chain_restriction has changed
371-
* from last command. used if set_mode is
372-
* IWL_TX_POWER_MODE_SET_SAR_TIMER.
373-
* note: if not changed, the command is used for keep alive only.
374-
* @reserved: reserved (padding)
375-
* @timer_period: timer in milliseconds. if expires FW will change to default
376-
* BIOS values. relevant if setMode is IWL_TX_POWER_MODE_SET_SAR_TIMER
377-
* @flags: reduce power flags.
378-
*/
379-
struct iwl_dev_tx_power_cmd_v7 {
380-
__le16 per_chain[IWL_NUM_CHAIN_TABLES_V2][IWL_NUM_CHAIN_LIMITS][IWL_NUM_SUB_BANDS_V2];
381-
u8 enable_ack_reduction;
382-
u8 per_chain_restriction_changed;
383-
u8 reserved[2];
384-
__le32 timer_period;
385-
__le32 flags;
386-
} __packed; /* TX_REDUCED_POWER_API_S_VER_7 */
387-
388344
/**
389345
* struct iwl_dev_tx_power_cmd_v8 - TX power reduction command version 8
390346
* @per_chain: per chain restrictions
@@ -429,8 +385,6 @@ struct iwl_dev_tx_power_cmd_per_band {
429385
* @v3: version 3 part of the command
430386
* @v4: version 4 part of the command
431387
* @v5: version 5 part of the command
432-
* @v6: version 6 part of the command
433-
* @v7: version 7 part of the command
434388
* @v8: version 8 part of the command
435389
*/
436390
struct iwl_dev_tx_power_cmd_v3_v8 {
@@ -440,8 +394,6 @@ struct iwl_dev_tx_power_cmd_v3_v8 {
440394
struct iwl_dev_tx_power_cmd_v3 v3;
441395
struct iwl_dev_tx_power_cmd_v4 v4;
442396
struct iwl_dev_tx_power_cmd_v5 v5;
443-
struct iwl_dev_tx_power_cmd_v6 v6;
444-
struct iwl_dev_tx_power_cmd_v7 v7;
445397
struct iwl_dev_tx_power_cmd_v8 v8;
446398
};
447399
};

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -888,17 +888,11 @@ int iwl_mvm_sar_select_profile(struct iwl_mvm *mvm, int prof_a, int prof_b)
888888
len = sizeof(cmd_v9_v10.v9);
889889
n_subbands = IWL_NUM_SUB_BANDS_V1;
890890
per_chain = &cmd_v9_v10.v9.per_chain[0][0];
891-
} else if (cmd_ver >= 7) {
892-
len = sizeof(cmd.v7);
891+
} else if (cmd_ver == 8) {
892+
len = sizeof(cmd.v8);
893893
n_subbands = IWL_NUM_SUB_BANDS_V2;
894-
per_chain = cmd.v7.per_chain[0][0];
895-
cmd.v7.flags = cpu_to_le32(mvm->fwrt.reduced_power_flags);
896-
if (cmd_ver == 8)
897-
len = sizeof(cmd.v8);
898-
} else if (cmd_ver == 6) {
899-
len = sizeof(cmd.v6);
900-
n_subbands = IWL_NUM_SUB_BANDS_V2;
901-
per_chain = cmd.v6.per_chain[0][0];
894+
per_chain = cmd.v8.per_chain[0][0];
895+
cmd.v8.flags = cpu_to_le32(mvm->fwrt.reduced_power_flags);
902896
} else if (fw_has_api(&mvm->fw->ucode_capa,
903897
IWL_UCODE_TLV_API_REDUCE_TX_POWER)) {
904898
len = sizeof(cmd.v5);

drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1515,10 +1515,6 @@ int iwl_mvm_set_tx_power(struct iwl_mvm *mvm,
15151515
len = sizeof(cmd_v9_v10.v9);
15161516
else if (cmd_ver == 8)
15171517
len = sizeof(cmd.v8);
1518-
else if (cmd_ver == 7)
1519-
len = sizeof(cmd.v7);
1520-
else if (cmd_ver == 6)
1521-
len = sizeof(cmd.v6);
15221518
else if (fw_has_api(&mvm->fw->ucode_capa,
15231519
IWL_UCODE_TLV_API_REDUCE_TX_POWER))
15241520
len = sizeof(cmd.v5);

0 commit comments

Comments
 (0)