Skip to content

Commit e8ab231

Browse files
vvfedorenkokuba-moo
authored andcommitted
net: ethtool: tsconfig: set command must provide a reply
Timestamping configuration through ethtool has inconsistent behavior of skipping the reply for set command if configuration was not changed. Fix it be providing reply in any case. Fixes: 6e9e2ee ("net: ethtool: Add support for tsconfig command to get/set hwtstamp config") Signed-off-by: Vadim Fedorenko <[email protected]> Reviewed-by: Kory Maincent <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent f67e9ae commit e8ab231

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

net/ethtool/tsconfig.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -423,13 +423,11 @@ static int ethnl_set_tsconfig(struct ethnl_req_info *req_base,
423423
return ret;
424424
}
425425

426-
if (hwprov_mod || config_mod) {
427-
ret = tsconfig_send_reply(dev, info);
428-
if (ret && ret != -EOPNOTSUPP) {
429-
NL_SET_ERR_MSG(info->extack,
430-
"error while reading the new configuration set");
431-
return ret;
432-
}
426+
ret = tsconfig_send_reply(dev, info);
427+
if (ret && ret != -EOPNOTSUPP) {
428+
NL_SET_ERR_MSG(info->extack,
429+
"error while reading the new configuration set");
430+
return ret;
433431
}
434432

435433
/* tsconfig has no notification */

0 commit comments

Comments
 (0)