Skip to content

Commit ee86cd9

Browse files
committed
wifi: iwlwifi: remove support of versions 4 and 5 of iwl_alive_ntf
These are not used in any of our devices. Remove them. Reviewed-by: Johannes Berg <[email protected]> Signed-off-by: Miri Korenblit <[email protected]> Link: https://patch.msgid.link/20250711183056.dd784443be53.I4ff3b2392294f5df2625a71e2deee3364e9708f6@changeid
1 parent 0356e50 commit ee86cd9

File tree

2 files changed

+16
-49
lines changed

2 files changed

+16
-49
lines changed

drivers/net/wireless/intel/iwlwifi/fw/api/alive.h

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -82,21 +82,6 @@ struct iwl_alive_ntf_v3 {
8282
struct iwl_umac_alive umac_data;
8383
} __packed; /* UCODE_ALIVE_NTFY_API_S_VER_3 */
8484

85-
struct iwl_alive_ntf_v4 {
86-
__le16 status;
87-
__le16 flags;
88-
struct iwl_lmac_alive lmac_data[2];
89-
struct iwl_umac_alive umac_data;
90-
} __packed; /* UCODE_ALIVE_NTFY_API_S_VER_4 */
91-
92-
struct iwl_alive_ntf_v5 {
93-
__le16 status;
94-
__le16 flags;
95-
struct iwl_lmac_alive lmac_data[2];
96-
struct iwl_umac_alive umac_data;
97-
struct iwl_sku_id sku_id;
98-
} __packed; /* UCODE_ALIVE_NTFY_API_S_VER_5 */
99-
10085
struct iwl_imr_alive_info {
10186
__le64 base_addr;
10287
__le32 size;

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

Lines changed: 16 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,22 @@ static bool iwl_alive_fn(struct iwl_notif_wait_data *notif_wait,
121121
return false;
122122

123123
palive = (void *)pkt->data;
124+
125+
umac = &palive->umac_data;
126+
lmac1 = &palive->lmac_data[0];
127+
lmac2 = &palive->lmac_data[1];
128+
status = le16_to_cpu(palive->status);
129+
130+
BUILD_BUG_ON(sizeof(palive->sku_id.data) !=
131+
sizeof(alive_data->sku_id));
132+
memcpy(alive_data->sku_id, palive->sku_id.data,
133+
sizeof(palive->sku_id.data));
134+
135+
IWL_DEBUG_FW(mvm, "Got sku_id: 0x0%x 0x0%x 0x0%x\n",
136+
le32_to_cpu(alive_data->sku_id[0]),
137+
le32_to_cpu(alive_data->sku_id[1]),
138+
le32_to_cpu(alive_data->sku_id[2]));
139+
124140
mvm->trans->dbg.imr_data.imr_enable =
125141
le32_to_cpu(palive->imr.enabled);
126142
mvm->trans->dbg.imr_data.imr_size =
@@ -168,40 +184,6 @@ static bool iwl_alive_fn(struct iwl_notif_wait_data *notif_wait,
168184
IWL_DEBUG_FW(mvm, "platform id: 0x%llx\n",
169185
palive_v8->platform_id);
170186
}
171-
}
172-
173-
if (version >= 5) {
174-
struct iwl_alive_ntf_v5 *palive;
175-
176-
if (pkt_len < sizeof(*palive))
177-
return false;
178-
179-
palive = (void *)pkt->data;
180-
umac = &palive->umac_data;
181-
lmac1 = &palive->lmac_data[0];
182-
lmac2 = &palive->lmac_data[1];
183-
status = le16_to_cpu(palive->status);
184-
185-
BUILD_BUG_ON(sizeof(palive->sku_id.data) !=
186-
sizeof(alive_data->sku_id));
187-
memcpy(alive_data->sku_id, palive->sku_id.data,
188-
sizeof(palive->sku_id.data));
189-
190-
IWL_DEBUG_FW(mvm, "Got sku_id: 0x0%x 0x0%x 0x0%x\n",
191-
le32_to_cpu(alive_data->sku_id[0]),
192-
le32_to_cpu(alive_data->sku_id[1]),
193-
le32_to_cpu(alive_data->sku_id[2]));
194-
} else if (iwl_rx_packet_payload_len(pkt) == sizeof(struct iwl_alive_ntf_v4)) {
195-
struct iwl_alive_ntf_v4 *palive;
196-
197-
if (pkt_len < sizeof(*palive))
198-
return false;
199-
200-
palive = (void *)pkt->data;
201-
umac = &palive->umac_data;
202-
lmac1 = &palive->lmac_data[0];
203-
lmac2 = &palive->lmac_data[1];
204-
status = le16_to_cpu(palive->status);
205187
} else if (iwl_rx_packet_payload_len(pkt) ==
206188
sizeof(struct iwl_alive_ntf_v3)) {
207189
struct iwl_alive_ntf_v3 *palive3;

0 commit comments

Comments
 (0)