Skip to content

Commit f2b8ebf

Browse files
lategoodbyegregkh
authored andcommitted
staging: vchiq_arm: Make vchiq_shutdown never fail
Most of the users of vchiq_shutdown ignore the return value, which is bad because this could lead to resource leaks. So instead of changing all calls to vchiq_shutdown, it's easier to make vchiq_shutdown never fail. Fixes: 71bad7f ("staging: add bcm2708 vchiq driver") Signed-off-by: Stefan Wahren <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 228af5a commit f2b8ebf

File tree

1 file changed

+1
-2
lines changed
  • drivers/staging/vc04_services/interface/vchiq_arm

1 file changed

+1
-2
lines changed

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -393,8 +393,7 @@ int vchiq_shutdown(struct vchiq_instance *instance)
393393
struct vchiq_state *state = instance->state;
394394
int ret = 0;
395395

396-
if (mutex_lock_killable(&state->mutex))
397-
return -EAGAIN;
396+
mutex_lock(&state->mutex);
398397

399398
/* Remove all services */
400399
vchiq_shutdown_internal(state, instance);

0 commit comments

Comments
 (0)