Skip to content

Commit fb2f2a8

Browse files
dmertmananguy11
authored andcommitted
ice: cleanup capabilities evaluation
When evaluating the capabilities field, the ICE_AQC_BIT_ROCEV2_LAG and ICE_AQC_BIT_SRIOV_LAG defines were both not using the BIT operator, instead simply setting a hex value that set the correct bits. While not inaccurate, this method is misleading, and when it is expanded in the following implementation it becomes even more confusing. Switch to using the BIT() operator to clarify what is being checked. Reviewed-by: Przemek Kitszel <[email protected]> Reviewed-by: Aleksandr Loktionov <[email protected]> Reviewed-by: Marcin Szycik <[email protected]> Signed-off-by: Dave Ertman <[email protected]> Tested-by: Sujai Buvaneswaran <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent 148c8cb commit fb2f2a8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/linux/net/intel/libie/adminq.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,8 @@ LIBIE_CHECK_STRUCT_LEN(16, libie_aqc_list_caps);
192192
#define LIBIE_AQC_CAPS_TX_SCHED_TOPO_COMP_MODE 0x0085
193193
#define LIBIE_AQC_CAPS_NAC_TOPOLOGY 0x0087
194194
#define LIBIE_AQC_CAPS_FW_LAG_SUPPORT 0x0092
195-
#define LIBIE_AQC_BIT_ROCEV2_LAG 0x01
196-
#define LIBIE_AQC_BIT_SRIOV_LAG 0x02
195+
#define LIBIE_AQC_BIT_ROCEV2_LAG BIT(0)
196+
#define LIBIE_AQC_BIT_SRIOV_LAG BIT(1)
197197
#define LIBIE_AQC_CAPS_FLEX10 0x00F1
198198
#define LIBIE_AQC_CAPS_CEM 0x00F2
199199

0 commit comments

Comments
 (0)