Skip to content

Commit fddf72e

Browse files
Marc Zyngierbjorn-helgaas
authored andcommitted
PCI: xgene: Drop XGENE_PCIE_IP_VER_UNKN
XGENE_PCIE_IP_VER_UNKN is only refered to when probing for the original XGene PCIe implementation, and get immediately overridden if the device has the "apm,xgene-pcie" compatible string. Given that the only way to get there is by finding this very string in the DT, it is obvious that we will always overwrite the version with XGENE_PCIE_IP_VER_1. Drop the whole thing. Signed-off-by: Marc Zyngier <[email protected]> Signed-off-by: Lorenzo Pieralisi <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent e3ac25c commit fddf72e

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

drivers/pci/controller/pci-xgene.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@
5454
#define XGENE_V1_PCI_EXP_CAP 0x40
5555

5656
/* PCIe IP version */
57-
#define XGENE_PCIE_IP_VER_UNKN 0
5857
#define XGENE_PCIE_IP_VER_1 1
5958
#define XGENE_PCIE_IP_VER_2 2
6059

@@ -630,10 +629,7 @@ static int xgene_pcie_probe(struct platform_device *pdev)
630629

631630
port->node = of_node_get(dn);
632631
port->dev = dev;
633-
634-
port->version = XGENE_PCIE_IP_VER_UNKN;
635-
if (of_device_is_compatible(port->node, "apm,xgene-pcie"))
636-
port->version = XGENE_PCIE_IP_VER_1;
632+
port->version = XGENE_PCIE_IP_VER_1;
637633

638634
ret = xgene_pcie_map_reg(port, pdev);
639635
if (ret)

0 commit comments

Comments
 (0)