bpf: Improve the general precision of tnum_mul #5815
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 4223bf8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
07f2c0d to
3a9c841
Compare
Author
|
Upstream branch: f4c227c |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995473=>bpf-next
branch
from
6f3fc0b to
4af2b91
Compare
Author
|
Upstream branch: f4c227c |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995473=>bpf-next
branch
from
4af2b91 to
f84f825
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
3a9c841 to
f4881a6
Compare
Author
|
Upstream branch: d0f27ff |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995473=>bpf-next
branch
from
f84f825 to
c0ae46d
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
f4881a6 to
8f9c214
Compare
Drop the value-mask decomposition technique and adopt straightforward long-multiplication with a twist: when LSB(a) is uncertain, find the two partial products (for LSB(a) = known 0 and LSB(a) = known 1) and take a union. Experiment shows that applying this technique in long multiplication improves the precision in a significant number of cases (at the cost of losing precision in a relatively lower number of cases). Signed-off-by: Nandakumar Edamana <[email protected]> Acked-by: Eduard Zingerman <[email protected]> Reviewed-by: Harishankar Vishwanathan <[email protected]> Tested-by: Harishankar Vishwanathan <[email protected]> # Agni
Add new selftest to test the abstract multiplication technique(s) used by the verifier, following the recent improvement in tnum multiplication (tnum_mul). One of the newly added programs, verifier_mul/mul_precise, results in a false positive with the old tnum_mul, while the program passes with the latest one. Signed-off-by: Nandakumar Edamana <[email protected]> Acked-by: Eduard Zingerman <[email protected]> Reviewed-by: Harishankar Vishwanathan <[email protected]>
Author
|
Upstream branch: 2465bb8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995473=>bpf-next
branch
from
c0ae46d to
8a3edb7
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
2 times, most recently
from
c9c941d to
c640618
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=995473 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Improve the general precision of tnum_mul
version: 6
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=995473