selftests/bpf: fix flaky bpf_cookie selftest #6031
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: bpf_cookie selftest fails if it runs after task_work selftest: perf_event_open fails with errno=EINVAL. EINVAL indicates incorrect/invalid input argument, which in case of bpf_cookie can only point to sample_freq attribute. Possible root cause: When running task_work test, we can see that perf subsystem lowers kernel.perf_event_max_sample_rate which probably is the side-effect of the test that make bpf_cookie fail. Solution: Set perf_event_open sampling rate attribute for bpf_cookie the same as task_work - this is the most reliable solution for this, changing task_work sampling rate resulted in task_work test becoming flaky. Signed-off-by: Mykyta Yatsenko <[email protected]>
task_work selftest does not properly handle cleanup during failures: * destroy bpf_link * perf event fd is passed to bpf_link, no need to close it if link was created successfully * goto cleanup if fork() failed, close pipe. Signed-off-by: Mykyta Yatsenko <[email protected]>
Author
|
Upstream branch: d4680a1 |
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1005633 expired. Closing PR. |
kernel-patches-daemon-bpf-rc
bot
deleted the
series/1005633=>bpf-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: fix flaky bpf_cookie selftest
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1005633